Skip to content

Conversation

zelinh
Copy link
Member

@zelinh zelinh commented Sep 10, 2024

Description

Split filter News to Blogs and Events to be more specific on the results landing page. The infra backend is already supported with the new parameter and this PR is to update on the front end UI side.

These changes will also need to be backported to all branches.

Issues Resolved

Part of opensearch-project/project-website-search#66

Version

All.

Frontend features

Screenshot 2024-09-10 at 3 24 00 PM

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @zelinh!

@kolchfa-aws kolchfa-aws added backport 1.3 PR: Backport label for v1.3.x backport 2.0 PR: Backport label for v2.0.x backport 2.1 PR: Backport label for 2.1 backport 2.2 PR: Backport label for 2.2 backport 2.3 PR: Backport label for 2.3 backport 2.4 PR: Backport label for 2.4 backport 2.5 PR: Backport label for 2.5 backport 2.6 PR: Backport label for 2.6 backport 2.7 PR: Backport label for 2.7 backport 2.8 PR: Backport label for 2.8 backport 2.9 PR: Backport label for 2.9 backport 2.10 PR: Backport label for 2.10 backport 2.11 PR: Backport label for 2.11 backport 2.12 PR: Backport label for 2.12 backport 2.13 PR: Backport label for 2.13 backport 2.14 PR: Backport label for 2.14 backport 2.15 labels Sep 11, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 16, 2024
* Add new filters for events and blogs

Signed-off-by: Zelin Hao <[email protected]>

* Update the breakline style

Signed-off-by: Zelin Hao <[email protected]>

---------

Signed-off-by: Zelin Hao <[email protected]>
(cherry picked from commit 4da6b67)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 16, 2024
* Add new filters for events and blogs

Signed-off-by: Zelin Hao <[email protected]>

* Update the breakline style

Signed-off-by: Zelin Hao <[email protected]>

---------

Signed-off-by: Zelin Hao <[email protected]>
(cherry picked from commit 4da6b67)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 16, 2024
* Add new filters for events and blogs

Signed-off-by: Zelin Hao <[email protected]>

* Update the breakline style

Signed-off-by: Zelin Hao <[email protected]>

---------

Signed-off-by: Zelin Hao <[email protected]>
(cherry picked from commit 4da6b67)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 16, 2024
* Add new filters for events and blogs

Signed-off-by: Zelin Hao <[email protected]>

* Update the breakline style

Signed-off-by: Zelin Hao <[email protected]>

---------

Signed-off-by: Zelin Hao <[email protected]>
(cherry picked from commit 4da6b67)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 16, 2024
* Add new filters for events and blogs

Signed-off-by: Zelin Hao <[email protected]>

* Update the breakline style

Signed-off-by: Zelin Hao <[email protected]>

---------

Signed-off-by: Zelin Hao <[email protected]>
(cherry picked from commit 4da6b67)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
noahstaveley pushed a commit to noahstaveley/documentation-website that referenced this pull request Sep 23, 2024
* Add new filters for events and blogs

Signed-off-by: Zelin Hao <[email protected]>

* Update the breakline style

Signed-off-by: Zelin Hao <[email protected]>

---------

Signed-off-by: Zelin Hao <[email protected]>
Signed-off-by: Noah Staveley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 1.3 PR: Backport label for v1.3.x backport 2.0 PR: Backport label for v2.0.x backport 2.1 PR: Backport label for 2.1 backport 2.2 PR: Backport label for 2.2 backport 2.3 PR: Backport label for 2.3 backport 2.4 PR: Backport label for 2.4 backport 2.5 PR: Backport label for 2.5 backport 2.6 PR: Backport label for 2.6 backport 2.7 PR: Backport label for 2.7 backport 2.8 PR: Backport label for 2.8 backport 2.9 PR: Backport label for 2.9 backport 2.10 PR: Backport label for 2.10 backport 2.11 PR: Backport label for 2.11 backport 2.12 PR: Backport label for 2.12 backport 2.13 PR: Backport label for 2.13 backport 2.14 PR: Backport label for 2.14 backport 2.15 backport 2.16

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants