chore: correct NDJSON extension for sample ecommerce data #8348
Conversation
Signed-off-by: hainenber <[email protected]>
hainenber
requested review from
AMoo-Miki,
Naarcha-AWS,
dlvenable,
epugh,
kolchfa-aws,
natebower,
stephen-crawford and
vagimeli
as code owners
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
|
@peterzhuamazon Could you please review this PR? |
|
@mgodwan Could you please review this PR? |
|
@hainenber For my understanding, this is mostly around representation, or did you also experience issues while following this guide due to mismatch of content-type and actual file spec? |
| 1. Define the field mappings provided in the mapping file: | ||
| ```bash | ||
| curl -H "Content-Type: application/x-ndjson" -X PUT "https://localhost:9200/ecommerce" -ku admin:<custom-admin-password> --data-binary "@ecommerce-field_mappings.json" | ||
| curl -H "Content-Type: application/json" -X PUT "https://localhost:9200/ecommerce" -ku admin:<custom-admin-password> --data-binary "@ecommerce-field_mappings.json" |
|
Thanks for the review @mgodwan It is only for representation. I've got no issue running the old cuủls. |
There was a problem hiding this comment.
Thank you, @hainenber! And thank you @mgodwan for the review. Ready to merge.
Signed-off-by: hainenber <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> (cherry picked from commit 4bb49d3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ject#8348) Signed-off-by: hainenber <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: [email protected] <[email protected]>
…ject#8348) Signed-off-by: hainenber <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: [email protected] <[email protected]>
…ject#8348) Signed-off-by: hainenber <[email protected]> Co-authored-by: kolchfa-aws <[email protected]>
3 participants
Description
Describe what this change achieves.
The sample ecommerce data file is not JSON per se but actually is
[NDJSON](https://github.com/ndjson/ndjson-spec?tab=readme-ov-file)as suggested by the accompanying Content-Type header.This PR is to remediate it.
Issues Resolved
Closes #[insert issue number]
N/A
Version
List the OpenSearch version to which this PR applies, e.g. 2.14, 2.12--2.14, or all.
All
Frontend features
If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.
N/A
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.