Skip to content

Conversation

ryanbogan
Copy link
Member

Description

Currently, the disk based vector search and k-NN vector quantization files have an incorrect search query. They specify method_params as an option, when it should be method_parameters. This PR modifies the files to say method_parameters.

Version

2.17

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ryanbogan!

@kolchfa-aws kolchfa-aws added the backport 2.17 Backport for version 2.17 label Sep 24, 2024
@kolchfa-aws kolchfa-aws merged commit d9829d7 into opensearch-project:main Sep 24, 2024
8 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 24, 2024
Signed-off-by: Ryan Bogan <[email protected]>
(cherry picked from commit d9829d7)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@ryanbogan ryanbogan deleted the fix_knn_search_json branch September 24, 2024 14:15
leanneeliatra pushed a commit to leanneeliatra/opensearch-documentation-website-forl that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.17 Backport for version 2.17

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants