Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding stop_replication action to ism documentation #9371

Merged
merged 7 commits into from
Apr 9, 2025
Merged

Adding stop_replication action to ism documentation #9371

merged 7 commits into from
Apr 9, 2025

Conversation

aggarwalShivani
Copy link
Contributor

Description

Adding documentation for new action "stop_replication" added in index-management plugin - opensearch-project/index-management#1198

Issues Resolved

Related to #726

Version

PR applies to upcoming versions 3.0.0-alpha1 and 2.20 (unreleased yet).

Frontend features

If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2025

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

@aggarwalShivani
Copy link
Contributor Author

Hi @bowenlan-amzn
Requesting tech-review 🙂

@Naarcha-AWS Naarcha-AWS added 3 - Tech review PR: Tech review in progress release-notes PR: Include this PR in the automated release notes labels Mar 7, 2025
bowenlan-amzn
bowenlan-amzn approved these changes Mar 7, 2025
View reviewed changes
@aggarwalShivani @bowenlan-amzn
Apply suggestions from code review
f57b4eb 
Co-authored-by: bowenlan-amzn <[email protected]>
Signed-off-by: aggarwalShivani <[email protected]>
@aggarwalShivani
Copy link
Contributor Author

aggarwalShivani commented Mar 11, 2025 •
edited
Loading

Hi @Naarcha-AWS,
Tech review is completed. Requesting you to please help with doc review.
Thanks!

@aggarwalShivani
Copy link
Contributor Author

Hi @Naarcha-AWS
Can you please help with doc review?

@aggarwalShivani
Copy link
Contributor Author

Hi @Naarcha-AWS
Can you please review this?

Opensearch 3.0.0-alpha1 is already released 12d back, which contains the said ism feature.
Request you to pls help with the review, so that the required documentation gets updated for users trying to enable this feature.

Awaiting feedback..

@aggarwalShivani
Copy link
Contributor Author

Hi @Naarcha-AWS
Please let me know if there’s anything I should address to get this change merged faster. Appreciate your help!

Request you to redirect to the right point of contact as necessary.

@kolchfa-aws kolchfa-aws added 4 - Doc review PR: Doc review in progress and removed 3 - Tech review PR: Tech review in progress labels Apr 8, 2025
kolchfa-aws
kolchfa-aws approved these changes Apr 9, 2025
View reviewed changes
Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @aggarwalShivani!

@aggarwalShivani
Copy link
Contributor Author

Hi @kolchfa-aws
Thank you very much for the review. Really appreciate this :)
I've accepted all the suggestions and committed. If any more changes are still needed, pls let me know.

Thanks!

@kolchfa-aws
Copy link
Collaborator

Thanks, @aggarwalShivani! Moving the PR to editorial review.

@kolchfa-aws kolchfa-aws added 5 - Editorial review PR: Editorial review in progress and removed 4 - Doc review PR: Doc review in progress labels Apr 9, 2025
natebower
natebower approved these changes Apr 9, 2025
View reviewed changes
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolchfa-aws kolchfa-aws merged commit 0c39a76 into opensearch-project:main Apr 9, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolchfa-aws kolchfa-aws kolchfa-aws approved these changes

@bowenlan-amzn bowenlan-amzn bowenlan-amzn approved these changes

@natebower natebower natebower approved these changes

@Naarcha-AWS Naarcha-AWS Awaiting requested review from Naarcha-AWS Naarcha-AWS is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@dlvenable dlvenable Awaiting requested review from dlvenable dlvenable is a code owner

@epugh epugh Awaiting requested review from epugh epugh is a code owner

Assignees

@kolchfa-aws kolchfa-aws

Labels
5 - Editorial review PR: Editorial review in progress release-notes PR: Include this PR in the automated release notes v3.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aggarwalShivani @kolchfa-aws @bowenlan-amzn @natebower @Naarcha-AWS