Skip to content

adding format mapping parameter docs#9507

Merged
natebower merged 9 commits into
opensearch-project:mainfrom
AntonEliatra:adding-format-mapping-parameter-docs
Apr 15, 2025
Merged

adding format mapping parameter docs#9507
natebower merged 9 commits into
opensearch-project:mainfrom
AntonEliatra:adding-format-mapping-parameter-docs

Conversation

@AntonEliatra

Copy link
Copy Markdown
Contributor

Description

Adding format mapping parameter docs

Version

all

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Anton Rubin <anton.rubin@eliatra.com>
@github-actions

Copy link
Copy Markdown

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

Signed-off-by: Anton Rubin <anton.rubin@eliatra.com>
Signed-off-by: Anton Rubin <anton.rubin@eliatra.com>
@AntonEliatra

Copy link
Copy Markdown
Contributor Author

@kolchfa-aws this PR is ready for review

Signed-off-by: Anton Rubin <anton.rubin@eliatra.com>
@kolchfa-aws

Copy link
Copy Markdown
Collaborator

@dhwanilpatel Could you please review this PR? Thank you!

@kolchfa-aws kolchfa-aws left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @AntonEliatra! Please see my comments/suggestions and let me know if you have any questions.

Comment thread _field-types/mapping-parameters/format.md Outdated
Comment thread _field-types/mapping-parameters/format.md Outdated
Comment thread _field-types/mapping-parameters/format.md Outdated
Comment thread _field-types/mapping-parameters/format.md Outdated
Comment thread _field-types/mapping-parameters/format.md Outdated
Comment thread _field-types/mapping-parameters/format.md Outdated
Comment thread _field-types/mapping-parameters/format.md Outdated
Comment thread _field-types/mapping-parameters/format.md
@kolchfa-aws kolchfa-aws added Doc review PR: Doc review in progress and removed Tech review PR: Tech review in progress labels Apr 11, 2025
AntonEliatra and others added 2 commits April 11, 2025 18:34
Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
Signed-off-by: AntonEliatra <anton.rubin@eliatra.com>
Signed-off-by: Anton Rubin <anton.rubin@eliatra.com>
@kolchfa-aws kolchfa-aws added 5 - Editorial review and removed Doc review PR: Doc review in progress labels Apr 11, 2025
Comment thread _field-types/mapping-parameters/format.md Outdated
AntonEliatra and others added 2 commits April 11, 2025 22:56
Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
Signed-off-by: AntonEliatra <anton.rubin@eliatra.com>

@natebower natebower left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AntonEliatra A few minor changes. Please tag me for approval when addressed. Thanks!

Comment thread _field-types/mapping-parameters/format.md Outdated
Comment thread _field-types/mapping-parameters/index.md Outdated
Comment thread _field-types/mapping-parameters/index.md Outdated
Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: AntonEliatra <anton.rubin@eliatra.com>

@natebower natebower left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AntonEliatra! LGTM

@natebower natebower merged commit 3973156 into opensearch-project:main Apr 15, 2025
opensearch-trigger-bot Bot pushed a commit that referenced this pull request Apr 15, 2025
* adding format mapping parameter docs

Signed-off-by: Anton Rubin <anton.rubin@eliatra.com>

* adding format mapping parameter docs

Signed-off-by: Anton Rubin <anton.rubin@eliatra.com>

* fixing vale errors

Signed-off-by: Anton Rubin <anton.rubin@eliatra.com>

* updating links on index page

Signed-off-by: Anton Rubin <anton.rubin@eliatra.com>

* Apply suggestions from code review

Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
Signed-off-by: AntonEliatra <anton.rubin@eliatra.com>

* updating as pr review comments

Signed-off-by: Anton Rubin <anton.rubin@eliatra.com>

* Apply suggestions from code review

Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
Signed-off-by: AntonEliatra <anton.rubin@eliatra.com>

* Apply suggestions from code review

Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: AntonEliatra <anton.rubin@eliatra.com>

---------

Signed-off-by: Anton Rubin <anton.rubin@eliatra.com>
Signed-off-by: AntonEliatra <anton.rubin@eliatra.com>
Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
Co-authored-by: Nathan Bower <nbower@amazon.com>
(cherry picked from commit 3973156)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@AntonEliatra AntonEliatra deleted the adding-format-mapping-parameter-docs branch April 16, 2025 17:10
epugh pushed a commit to o19s/documentation-website that referenced this pull request Jul 2, 2025
* adding format mapping parameter docs

Signed-off-by: Anton Rubin <anton.rubin@eliatra.com>

* adding format mapping parameter docs

Signed-off-by: Anton Rubin <anton.rubin@eliatra.com>

* fixing vale errors

Signed-off-by: Anton Rubin <anton.rubin@eliatra.com>

* updating links on index page

Signed-off-by: Anton Rubin <anton.rubin@eliatra.com>

* Apply suggestions from code review

Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
Signed-off-by: AntonEliatra <anton.rubin@eliatra.com>

* updating as pr review comments

Signed-off-by: Anton Rubin <anton.rubin@eliatra.com>

* Apply suggestions from code review

Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
Signed-off-by: AntonEliatra <anton.rubin@eliatra.com>

* Apply suggestions from code review

Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: AntonEliatra <anton.rubin@eliatra.com>

---------

Signed-off-by: Anton Rubin <anton.rubin@eliatra.com>
Signed-off-by: AntonEliatra <anton.rubin@eliatra.com>
Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Eric Pugh <epugh@opensourceconnections.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants