Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get bouncycastle dependency version from catalog #1078

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

dbwiddis
Copy link
Member

Description

Gets the version of org.bouncycastle:bcprov-jdk18on from the OpenSearch version catalog

Related Issues

Fixes #1072

Check List

  • New functionality includes testing.
  • ![ ] New functionality has been documented.!
  • ![ ] API changes companion pull request created.!
  • Commits are signed per the DCO using --signoff.
  • [ ] Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.57%. Comparing base (88fe98e) to head (46447cc).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1078   +/-   ##
=========================================
  Coverage     75.57%   75.57%           
  Complexity     1050     1050           
=========================================
  Files           101      101           
  Lines          5212     5212           
  Branches        498      498           
=========================================
  Hits           3939     3939           
  Misses         1035     1035           
  Partials        238      238           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joshpalis joshpalis merged commit 0a19823 into opensearch-project:main Mar 11, 2025
26 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/flow-framework/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/flow-framework/backport-2.x
# Create a new branch
git switch --create backport/backport-1078-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0a19823d3a290d0d7cbdaf070ddf08653dca5abe
# Push it to GitHub
git push --set-upstream origin backport/backport-1078-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/flow-framework/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1078-to-2.x.

@opensearch-trigger-bot opensearch-trigger-bot bot added the backport-failed Applied to PRs when the automatic backport fails label Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport PRs to 2.x branch backport-failed Applied to PRs when the automatic backport fails skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Jar hell from org.bouncycastle:bcprov-jdk18on
3 participants