Changed return code for RBAC and provision

[owaiskazi19]

Description

Changed return code for RBAC

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

• New functionality includes testing.
• New functionality has been documented.
• API changes companion pull request created.
• Commits are signed per the DCO using --signoff.
• Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.30%. Comparing base (005029c) to head (29e1761).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...h/flowframework/rest/RestCreateWorkflowAction.java	0.00%	0 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #1083      +/-   ##
============================================
- Coverage     76.32%   76.30%   -0.02%     
- Complexity     1075     1076       +1     
============================================
  Files           101      101              
  Lines          5276     5276              
  Branches        503      504       +1     
============================================
- Hits           4027     4026       -1     
  Misses         1001     1001              
- Partials        248      249       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[dbwiddis]

Can we evaluate all the return codes and put them in a single PR?

I think provisioning should return a 202, for example.

Any others?

[owaiskazi19]

Can we evaluate all the return codes and put them in a single PR?

This was the only one I was aware of. Can you point me where should we return 202 I can make the changes in the same PR?

[amitgalitz]

Can we evaluate all the return codes and put them in a single PR?

This was the only one I was aware of. Can you point me where should we return 202 I can make the changes in the same PR?

Dan might mean here

flow-framework/src/main/java/org/opensearch/flowframework/rest/RestProvisionWorkflowAction.java

Line 103 in 005029c

channel.sendResponse(new BytesRestResponse(RestStatus.OK, builder));

[dbwiddis]

Dan might mean here

flow-framework/src/main/java/org/opensearch/flowframework/rest/RestProvisionWorkflowAction.java

Line 103 in 005029c

channel.sendResponse(new BytesRestResponse(RestStatus.OK, builder));

Yes, and also here if either provision or reprovision is true:

flow-framework/src/main/java/org/opensearch/flowframework/rest/RestCreateWorkflowAction.java

Line 256 in 005029c

channel.sendResponse(new BytesRestResponse(RestStatus.CREATED, builder));

[dbwiddis]

Yes, and also here if either provision or reprovision is true:

Although one might say 201 is still appropriate for provision; but should be 202 for reprovision, not 201.

@ohltyler thoughts?

[dbwiddis]

LGTM pending fixing tests for the new codes.

[dbwiddis]

These will probably need updates to the API Spec as well.

• https://github.com/opensearch-project/opensearch-api-specification/blob/5d1077e4fca43cebf284743b225da19c0e31026e/tests/default/flow_framework/workflow/provision.yaml#L35
• https://github.com/opensearch-project/opensearch-api-specification/blob/5d1077e4fca43cebf284743b225da19c0e31026e/tests/default/flow_framework/workflow/template.yaml#L138

[owaiskazi19]

These will probably need updates to the API Spec as well.

opensearch-project/opensearch-api-specification#842

[dbwiddis]

LGTM