Run tests with custom user attribute serialization #1484
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
cwperks
requested review from
Hailong-am,
bowenlan-amzn,
shiv0408,
soosinha,
tandonks and
vikasvb90
as code owners
Signed-off-by: Craig Perkins <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1484 +/- ##
==========================================
+ Coverage 76.27% 76.30% +0.03%
==========================================
Files 375 375
Lines 18772 18772
Branches 2366 2366
==========================================
+ Hits 14318 14324 +6
+ Misses 3218 3213 -5
+ Partials 1236 1235 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
| val explainResponseOpendistroPolicyIdSetting = "index.opendistro.index_state_management.policy_id" | ||
| val explainResponseOpenSearchPolicyIdSetting = "index.plugins.index_state_management.policy_id" | ||
|
|
||
| @Before |
There was a problem hiding this comment.
Could we just do this in one test? If the goal is to make sure an user's custom attribute can be persisted and updated in ISM system index?
Current way seems will apply to all the tests.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new mapping to the ISM system indices for
user_attributesthat was added in opensearch-project/common-utils#827This PR runs tests with a user that has custom attributes and verifies that persisting a copy of the user works correctly in ISM system indices.
Related Issues
Working towards a solution for opensearch-project/alerting#1829
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.