Fix the build #1491
Merged
Fix the build #1491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bowenlan-amzn <[email protected]>
|
@bowenlan-amzn for the common-utils related changes see opensearch-project/security-analytics#1583 as a reference. |
|
TY for this PR. I removed the LockService reference from other repos, but didn't realize that ISM also had some instances where it was instantiating a LockService. LockService has since moved to an interface to forbid other plugins from instantiating it. JobScheduler can instantiate and other plugins can get through dep injection. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1491 +/- ##
==========================================
- Coverage 76.23% 76.19% -0.04%
==========================================
Files 375 375
Lines 18773 18773
Branches 2366 2366
==========================================
- Hits 14311 14305 -6
- Misses 3223 3229 +6
Partials 1239 1239 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: bowenlan-amzn <[email protected]>
5 tasks
bowenlan-amzn
requested review from
Hailong-am,
shiv0408,
soosinha,
tandonks and
vikasvb90
as code owners
Hailong-am
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the build according to changes from upstream
opensearch-project/OpenSearch#19184 (comment)
opensearch-project/security-analytics#1583
opensearch-project/job-scheduler#714
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.