Skip to content

Use optionalField for creation in ExplainSMPolicy serialization #1507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+65 −6
Open

Use optionalField for creation in ExplainSMPolicy serialization #1507

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d0d9f83
Use optionalField for creation in ExplainSMPolicy serialization
Tarun-kishore Oct 13, 2025
5079606
Adding Version check
Tarun-kishore Oct 13, 2025
e2b98b5
Adding unit tests
Tarun-kishore Oct 17, 2025
ae99a59
Adding explain check in backward compatibility
Tarun-kishore Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/kotlin/org/opensearch/indexmanagement/snapshotmanagement/model/ExplainSMPolicy.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ data class ExplainSMPolicy(
override fun toXContent(builder: XContentBuilder, params: ToXContent.Params): XContentBuilder {
metadata?.let {
builder
.field(SMMetadata.CREATION_FIELD, it.creation)
.optionalField(SMMetadata.CREATION_FIELD, it.creation)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this have bwc issue when doing rolling upgrade? guess we need to add version check here

Copy link
Contributor Author

@Tarun-kishore Tarun-kishore Oct 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, Good catch. Added a version check.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hailong-am I added a version check for greater than 3.3 (which is current version). The coverage is failing though, version 3.4 needs to be available for testing it. Rest all CI workflows are passing.

.optionalField(SMMetadata.DELETION_FIELD, it.deletion)
.field(SMMetadata.POLICY_SEQ_NO_FIELD, it.policySeqNo)
.field(SMMetadata.POLICY_PRIMARY_TERM_FIELD, it.policyPrimaryTerm)
Expand Down
Loading