[Feature] Supporting Exclusion pattern in index pattern in ISM #1509
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements support for exclusion patterns in ISM template index patterns using the
-
prefix, similar to OpenSearch's native index pattern matching. This allows users to define broad inclusion patterns while excluding specific indices from automatic ISM policy management.Key Changes:
matchesIndexPatterns()
function inManagedIndexCoordinator
that separates inclusion and exclusion patterns, ensuring indices are only managed if they match an inclusion pattern and don't match any exclusion patternvalidateFormat()
inISMTemplateService
to accept and validate exclusion patterns (patterns prefixed with-
)findMatchingPolicy()
to use the new exclusion-aware matching logicExample Usage:
This configuration will:
logs-production-001
,logs-staging-001
logs-test-001
,logs-production-debug
Benefits:
GET /logs-*,-logs-test-*/_search
)Testing Demonstration
Step 1: Create Policy with Exclusion Patterns
Created an ISM policy with mixed inclusion and exclusion patterns:
Step 2: Create Test Indices
Created four test indices to verify the exclusion behavior:
test-10
- Should be managed (matchestest-1*
, not excluded)test-12
- Should NOT be managed (matches exclusion-test-12*
)test-30
- Should be managed (matchestest-3*
, not excluded)test-34
- Should NOT be managed (matches exclusion-test-34*
)Step 3: Verify with ISM Explain API
After coordinator processing, the ISM Explain API confirms the expected behavior:
test-10
test_exclusion_policy
test-12
test-30
test_exclusion_policy
test-34
Related Issues
Resolves #375
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.