Deprecate nmslib engine #2427
Open
Deprecate nmslib engine #2427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kotwanikunal
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan,
luyuncheng,
shatejas and
0ctopus13prime
as code owners
navneet1v
approved these changes
Jan 23, 2025
navneet1v
previously approved these changes
Jan 23, 2025
martin-gaievski
previously approved these changes
Jan 23, 2025
5 tasks
kotwanikunal
dismissed stale reviews from martin-gaievski, ryanbogan, and navneet1v
via
872caa4
kotwanikunal
force-pushed
the
deprecate-nmslib
branch
from
1122ce1 to
872caa4
Compare
ryanbogan
previously approved these changes
Feb 6, 2025
jmazanec15
previously approved these changes
Feb 6, 2025
|
@kotwanikunal Can we close this? |
Signed-off-by: Kunal Kotwani <[email protected]>
Signed-off-by: Kunal Kotwani <[email protected]>
kotwanikunal
force-pushed
the
deprecate-nmslib
branch
from
d400235 to
0cd17e4
Compare
|
@jmazanec15 We still need this. I have rebased the PR again. |
jmazanec15
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
nmslibengine supportRelated Issues
Check List
New functionality includes testing.API changes companion pull request created.--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.