Add VectorDataType check to NativeIndexBuildStrategy #2610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 tasks
jed326
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan,
luyuncheng,
shatejas,
0ctopus13prime and
Vikasht34
as code owners
navneet1v
previously approved these changes
Mar 17, 2025
owenhalpert
reviewed
Mar 17, 2025
jed326
force-pushed
the
float-check
branch
2 times, most recently
from
e715189 to
74d425d
Compare
owenhalpert
reviewed
Mar 17, 2025
src/main/java/org/opensearch/knn/index/engine/faiss/FaissHNSWMethod.java
Outdated
Show resolved
Hide resolved
|
LGTM thanks Jay, just looks like you need the CIs re-run |
owenhalpert
approved these changes
Mar 17, 2025
epalaz
approved these changes
Mar 18, 2025
src/main/java/org/opensearch/knn/index/engine/faiss/FaissHNSWMethod.java
Show resolved
Hide resolved
src/main/java/org/opensearch/knn/index/engine/faiss/FaissHNSWMethod.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jay Deng <[email protected]>
jmazanec15
approved these changes
Mar 18, 2025
navneet1v
approved these changes
Mar 18, 2025
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Check for supported
VectorDataTypeinNativeIndexBuildStrategyCheck List
- [ ] New functionality has been documented.- [ ] API changes companion pull request created.--signoff.- [ ] Public documentation issue/PR created.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.