Skip to content

Add KNN Profiling Info to Core Profiler - Lucene #2802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: feature/query-profiler
Choose a base branch
from
Open

Add KNN Profiling Info to Core Profiler - Lucene #2802

wants to merge 5 commits into from

Conversation

neuenfeldttj
Copy link
Contributor

Description

Resolves #2785. Added profile wrappers around lucene knn queries to use for profiling. Once opensearch-project/OpenSearch#18793 gets resolved then this can be refactored so that we are not unnecessarily creating profiler wrappers which already adds latency.

Related Issues

References #2785

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@neuenfeldttj
ported over lucene changes
4ecd600 
Signed-off-by: TJ Neuenfeldt <[email protected]>
@neuenfeldttj
javadoc doSearch
db065f1 
Signed-off-by: TJ Neuenfeldt <[email protected]>
shatejas
shatejas approved these changes Jul 24, 2025
View reviewed changes
Copy link
Collaborator

@shatejas shatejas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for now - This is pending 2 things to merge in main

  1. QueryshardContext needs a profile flag to be able to decide the right query in KNNfactory
  2. Lucene needs a vector query interface to not create large number of queries.

@jmazanec15
Copy link
Member

@markwu-sde

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shatejas shatejas shatejas approved these changes

@heemin32 heemin32 Awaiting requested review from heemin32 heemin32 is a code owner

@navneet1v navneet1v Awaiting requested review from navneet1v navneet1v is a code owner

@VijayanB VijayanB Awaiting requested review from VijayanB VijayanB is a code owner

@vamshin vamshin Awaiting requested review from vamshin vamshin is a code owner

@jmazanec15 jmazanec15 Awaiting requested review from jmazanec15 jmazanec15 is a code owner

@naveentatikonda naveentatikonda Awaiting requested review from naveentatikonda naveentatikonda is a code owner

@junqiu-lei junqiu-lei Awaiting requested review from junqiu-lei junqiu-lei is a code owner

@martin-gaievski martin-gaievski Awaiting requested review from martin-gaievski martin-gaievski is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan ryanbogan is a code owner

@luyuncheng luyuncheng Awaiting requested review from luyuncheng luyuncheng is a code owner

@0ctopus13prime 0ctopus13prime Awaiting requested review from 0ctopus13prime 0ctopus13prime is a code owner

@Vikasht34 Vikasht34 Awaiting requested review from Vikasht34 Vikasht34 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@neuenfeldttj @jmazanec15 @shatejas