Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Improve test coverage for MLEngineClassLoader class #1377

Open
dhrubo-os opened this issue Sep 25, 2023 · 6 comments · May be fixed by #3679
Open

[FEATURE] Improve test coverage for MLEngineClassLoader class #1377

dhrubo-os opened this issue Sep 25, 2023 · 6 comments · May be fixed by #3679
Assignees
@akolarkunnu
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@dhrubo-os
Copy link
Collaborator

dhrubo-os commented Sep 25, 2023 •
edited
Loading

We need to improve test coverage in our repo.

This issue will target only to improve test coverage for MLEngineClassLoader.java class

From this url we can see where test coverage is missing for this class: https://app.codecov.io/gh/opensearch-project/ml-commons/blob/2.x/ml-algorithms%2Fsrc%2Fmain%2Fjava%2Forg%2Fopensearch%2Fml%2Fengine%2FMLEngineClassLoader.java
@dhrubo-os dhrubo-os added enhancement New feature or request untriaged good first issue Good for newcomers and removed untriaged labels Sep 25, 2023
@dhrubo-os
Copy link
Collaborator Author

dhrubo-os commented Sep 25, 2023 •
edited
Loading

This is is created for CCI. Feel free to pick this issue.

Target is to increase the test coverage for this class. We already have some tests here
.

We need to extend more tests. So if you have any question related to that, please ask. Thanks

@dhrubo-os
Copy link
Collaborator Author

Sure, assigned it to you.

@vimalJD vimalJD removed their assignment Sep 25, 2023
@dhrubo-os
Copy link
Collaborator Author

You can do whenever you are ready to start coding.

@dhrubo-os
Copy link
Collaborator Author

@vimalJD any update on this?

@akolarkunnu
Copy link
Contributor

@dhrubo-os Can you please assign this to me ?

@dhrubo-os dhrubo-os assigned akolarkunnu and unassigned vimalJD Mar 20, 2025
@dhrubo-os
Copy link
Collaborator Author

Assigned it to you. Thanks for looking into this.

akolarkunnu added a commit to akolarkunnu/ml-commons that referenced this issue Mar 21, 2025
@akolarkunnu
[FEATURE] Improve test coverage for MLEngineClassLoader class
ba9a682 
Improved the test coverage by adding the edge case.
Some of the branch coverages which are mssing are unreachable code. The Function, ConnectorExecutor and Ingester values are non null.

Resolves opensearch-project#1377

Signed-off-by: Abdul Muneer Kolarkunnu <[email protected]>
@akolarkunnu akolarkunnu linked a pull request Mar 21, 2025 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akolarkunnu akolarkunnu

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FEATURE] Improve test coverage for MLEngineClassLoader class akolarkunnu/ml-commons
3 participants
@akolarkunnu @vimalJD @dhrubo-os