[FEATURE] Improve test coverage for MLEngineClassLoader class #3679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved the test coverage by adding the edge case. Some of the branch coverages which are mssing are unreachable code. The Function, ConnectorExecutor and Ingester values are non null. Resolves opensearch-project#1377 Signed-off-by: Abdul Muneer Kolarkunnu <[email protected]>
akolarkunnu
requested review from
b4sjoo,
dhrubo-os,
mingshl,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27 and
xinyual
as code owners
akolarkunnu
deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Active
akolarkunnu
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
akolarkunnu
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
akolarkunnu
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
|
Code Coverage report after fix: Missing branch coverages are unreachable code. With this fix, a little improvement is the in coverage. |
dhrubo-os
approved these changes
Mar 21, 2025
akolarkunnu
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
akolarkunnu
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improved the test coverage by adding the edge case of initInstance() method returns null.
Some of the branch coverages which are missing are unreachable code. The Function, ConnectorExecutor and Ingester values are non null.
Related Issues
Resolves #1377
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.