Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_cohereInference_withDifferent_postProcessFunction flaky test #3666

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix test_cohereInference_withDifferent_postProcessFunction flaky test #3666

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c614960
Fix test_cohereInference_withDifferent_postProcessFunction flaky test
nathaliellenaa Mar 17, 2025
fb59fb3
Apply feedback
nathaliellenaa Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion plugin/src/test/java/org/opensearch/ml/rest/RestCohereInferenceIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,9 @@ public void test_cohereInference_withDifferent_postProcessFunction() {
List output = (List) inferenceResult.get("inference_results");
assertEquals(errorMsg, 1, output.size());
assertTrue(errorMsg, output.get(0) instanceof Map);
validateOutput(errorMsg, (Map) output.get(0), DATA_TYPE.get(postProcessFunction));
if (output != null && DATA_TYPE != null) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DATA_TYPE is a static variable which already have values in it. So checking null for DATA_TYPE isn't adding any value because it will not be null.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, I'll remove the null check for DATA_TYPE.

validateOutput(errorMsg, (Map) output.get(0), DATA_TYPE.get(postProcessFunction));
}
}
}

Expand Down
Loading