deprecate the restful API of batch ingestion

[Zhangxunmt]

Description

Verified the Rest API of batch ingestion is deprecated. Will send out a separate PR for the tech doc.

POST /_plugins/_ml/_batch_ingestion
{
  "error": "no handler found for uri [/_plugins/_ml/_batch_ingestion] and method [POST]"
}

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

• New functionality includes testing.
• New functionality has been documented.
• API changes companion pull request created.
• Commits are signed per the DCO using --signoff.
• Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.35%. Comparing base (71b5998) to head (3b2895d).
Report is 3 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #3688      +/-   ##
============================================
+ Coverage     80.34%   80.35%   +0.01%     
- Complexity     7023     7024       +1     
============================================
  Files           615      615              
  Lines         30636    30635       -1     
  Branches       3447     3447              
============================================
+ Hits          24614    24617       +3     
+ Misses         4528     4525       -3     
+ Partials       1494     1493       -1     

Flag	Coverage Δ
ml-commons	80.35% <ø> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[mingshl]

is the MLBatchIngestionInput going to stay but only removing the REST API?

ml-commons/common/src/main/java/org/opensearch/ml/common/transport/batch/MLBatchIngestionInput.java

Line 29 in 1aa9327

public class MLBatchIngestionInput implements ToXContentObject, Writeable {

[Zhangxunmt]

is the MLBatchIngestionInput going to stay but only removing the REST API?

ml-commons/common/src/main/java/org/opensearch/ml/common/transport/batch/MLBatchIngestionInput.java

Line 29 in 1aa9327

public class MLBatchIngestionInput implements ToXContentObject, Writeable {

Yes so no one uses it directly. the transport layer API can still stay just in case the flow framework wants to integrate. We can remove all the code later once decided that this is not needed for sure.

[dhrubo-os]

is the MLBatchIngestionInput going to stay but only removing the REST API?

ml-commons/common/src/main/java/org/opensearch/ml/common/transport/batch/MLBatchIngestionInput.java

Line 29 in 1aa9327

public class MLBatchIngestionInput implements ToXContentObject, Writeable {

Why aren't we removing RestMLBatchIngestAction class then?

Also can you remove plugin/src/test/resources/org/opensearch/ml/bwc/2.4.0.0/opensearch-ml-2.4.0.0.zip from this PR?

[dhrubo-os]

POST /_plugins/_ml/_batch_ingestion
{
  "error": "no handler found for uri [/_plugins/_ml/_batch_ingestion] and method [POST]"
}

I assume there is no customer adoption to this feature yet? Otherwise this message doesn't seem right to me if any customer started using this feature already.

[Zhangxunmt]

POST /_plugins/_ml/_batch_ingestion
{
  "error": "no handler found for uri [/_plugins/_ml/_batch_ingestion] and method [POST]"
}

I assume there is no customer adoption to this feature yet? Otherwise this message doesn't seem right to me if any customer started using this feature already.

This API is stateless so no impact to existing Cx. Probably a better way is to return a deprecation message and asking the caller to check out data prepper in the rest class. But I guess overall the usage is low and this message shouldn’t matter that much.

[Zhangxunmt]

is the MLBatchIngestionInput going to stay but only removing the REST API?

ml-commons/common/src/main/java/org/opensearch/ml/common/transport/batch/MLBatchIngestionInput.java

Line 29 in 1aa9327

public class MLBatchIngestionInput implements ToXContentObject, Writeable {

Why aren't we removing RestMLBatchIngestAction class then?

Also can you remove plugin/src/test/resources/org/opensearch/ml/bwc/2.4.0.0/opensearch-ml-2.4.0.0.zip from this PR?

Thanks for the comment. Will remove "bwc/2.4.0.0/opensearch-ml-2.4.0.0.zip" in a separate PR.