Skip to content

DELETE Prompt API #3873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: feature/prompt
Choose a base branch
from
Draft

Conversation

rcho93
Copy link

@rcho93 rcho93 commented May 26, 2025

Description

Implements an API to delete a prompt

Related Issues

Resolves #3711

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@rcho93 rcho93 temporarily deployed to ml-commons-cicd-env-require-approval May 26, 2025 03:24 — with GitHub Actions Inactive
@rcho93 rcho93 temporarily deployed to ml-commons-cicd-env-require-approval May 26, 2025 03:24 — with GitHub Actions Inactive
@rcho93 rcho93 temporarily deployed to ml-commons-cicd-env-require-approval May 26, 2025 03:24 — with GitHub Actions Inactive
@rcho93 rcho93 temporarily deployed to ml-commons-cicd-env-require-approval May 26, 2025 03:24 — with GitHub Actions Inactive
Copy link

codecov bot commented May 26, 2025

Codecov Report

Attention: Patch coverage is 96.20253% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.25%. Comparing base (a21917c) to head (5543088).

Files with missing lines Patch % Lines
.../common/transport/prompt/MLPromptDeleteAction.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##             feature/prompt    #3873      +/-   ##
====================================================
+ Coverage             78.21%   78.25%   +0.03%     
- Complexity             7435     7458      +23     
====================================================
  Files                   668      672       +4     
  Lines                 33457    33536      +79     
  Branches               3738     3740       +2     
====================================================
+ Hits                  26170    26245      +75     
- Misses                 5691     5694       +3     
- Partials               1596     1597       +1     
Flag Coverage Δ
ml-commons 78.25% <96.20%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rcho93 rcho93 requested a deployment to ml-commons-cicd-env-require-approval May 26, 2025 17:22 — with GitHub Actions Waiting
@rcho93 rcho93 requested a deployment to ml-commons-cicd-env-require-approval May 26, 2025 17:22 — with GitHub Actions Waiting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant