[Agent] PlanExecuteReflect: Return memory early to track progress #3884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyek-bot
requested review from
b4sjoo,
dhrubo-os,
mingshl,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27 and
xinyual
as code owners
pyek-bot
requested a deployment
to
ml-commons-cicd-env-require-approval
GitHub Actions
Waiting
pyek-bot
requested a deployment
to
ml-commons-cicd-env-require-approval
GitHub Actions
Waiting
pyek-bot
requested a deployment
to
ml-commons-cicd-env-require-approval
GitHub Actions
Waiting
pyek-bot
requested a deployment
to
ml-commons-cicd-env-require-approval
GitHub Actions
Waiting
ylwu-amzn
reviewed
Jun 2, 2025
| @@ -0,0 +1,59 @@ | |||
| package org.opensearch.ml.common.utils; | |||
pyek-bot
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Error
pyek-bot
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Error
pyek-bot
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
pyek-bot
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
pyek-bot
commented
Jun 3, 2025
| public static final ImmutableSet<MLTaskState> TASK_DONE_STATES = ImmutableSet | ||
| .of(MLTaskState.COMPLETED, MLTaskState.COMPLETED_WITH_ERROR, MLTaskState.FAILED, MLTaskState.CANCELLED); | ||
|
|
||
| public static void updateMLTaskDirectly( |
There was a problem hiding this comment.
Moved this method here from MLAgentExecutor to facilitate reuse
Signed-off-by: Pavan Yekbote <[email protected]>
Signed-off-by: Pavan Yekbote <[email protected]>
Signed-off-by: Pavan Yekbote <[email protected]>
pyek-bot
force-pushed
the
executor_memory_id_consistent_returns
branch
from
a1de599 to
bae6369
Compare
pyek-bot
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Error
pyek-bot
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
pyek-bot
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
pyek-bot
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Error
mingshl
reviewed
Jun 3, 2025
| } | ||
| } catch (Exception e) { | ||
| log.error("Failed to update ML task {}", taskId, e); | ||
| listener.onFailure(e); |
There was a problem hiding this comment.
can you also add the "Failed to update ML task {}", taskId in the onFailure message?
There was a problem hiding this comment.
onFailure accepts an exception. So do you want me to wrap the thrown exception with the message:
listener.onFailure(new Exception(String.format("Failed to update ML Task: %s, taskId), e)));
There was a problem hiding this comment.
yes, use a new MLException please
There was a problem hiding this comment.
Is this 5XX or 4XX level error.
There was a problem hiding this comment.
This try-catch is redundant, I have removed it. The only try-catch now is try-with-resources for the ThreadContext and I guess this should be 4XX errors.
ml-algorithms/src/main/java/org/opensearch/ml/engine/algorithms/agent/MLAgentExecutor.java
Show resolved
Hide resolved
|
please add UT to verify your change is expected |
|
The current test failure is added in this PR: #3882 |
jiapingzeng
approved these changes
Jun 3, 2025
dhrubo-os
requested a deployment
to
ml-commons-cicd-env-require-approval
GitHub Actions
Waiting
dhrubo-os
requested a deployment
to
ml-commons-cicd-env-require-approval
GitHub Actions
Waiting
dhrubo-os
requested a deployment
to
ml-commons-cicd-env-require-approval
GitHub Actions
Waiting
dhrubo-os
requested a deployment
to
ml-commons-cicd-env-require-approval
GitHub Actions
Waiting
Signed-off-by: Pavan Yekbote <[email protected]>
pyek-bot
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
pyek-bot
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
pyek-bot
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
pyek-bot
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Error
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3884 +/- ##
============================================
- Coverage 78.84% 78.79% -0.05%
Complexity 7452 7452
============================================
Files 658 659 +1
Lines 33280 33299 +19
Branches 3750 3754 +4
============================================
- Hits 26240 26239 -1
- Misses 5393 5411 +18
- Partials 1647 1649 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pyek-bot
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
pyek-bot
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Resolves #3881
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.