Skip to content

Conversation

dhrubo-os
Copy link
Collaborator

Description

[bug fix ] #4141

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

nathaliellenaa and others added 5 commits August 28, 2025 19:47
* Update maintainer list

Signed-off-by: Nathalie Jonathan <[email protected]>

* Update maintainer list

Signed-off-by: Nathalie Jonathan <[email protected]>

* Fix format

Signed-off-by: Nathalie Jonathan <[email protected]>

* Add @sam-herman as a code owner

Signed-off-by: Peter Zhu <[email protected]>

* Fix GitHub link for Samuel Herman

Updated GitHub link for Samuel Herman.

Signed-off-by: Peter Zhu <[email protected]>

---------

Signed-off-by: Nathalie Jonathan <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Co-authored-by: Peter Zhu <[email protected]>
…t#4121)

* poc

Signed-off-by: Shiqi Xia <[email protected]>

* version that run correctly

Signed-off-by: Shiqi Xia <[email protected]>

* passed all UT

Signed-off-by: Shiqi Xia <[email protected]>

* passed all UT

Signed-off-by: Shiqi Xia <[email protected]>

* Remove the removeMissParameterFields

Signed-off-by: Shiqi Xia <[email protected]>

---------

Signed-off-by: Shiqi Xia <[email protected]>
Co-authored-by: Xia <[email protected]>
…4111)

* Add ml commons passthrough post process function

Signed-off-by: Andy Qin <[email protected]>

* Apply spotless

Signed-off-by: Andy Qin <[email protected]>

* Add more comments and refactor

Signed-off-by: Andy Qin <[email protected]>

---------

Signed-off-by: Andy Qin <[email protected]>
Signed-off-by: Dhrubo Saha <[email protected]>
b4sjoo
b4sjoo previously approved these changes Aug 31, 2025
xinyual
xinyual previously approved these changes Sep 1, 2025
Copy link
Contributor

@akolarkunnu akolarkunnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

nathaliellenaa and others added 2 commits September 2, 2025 18:02
* Fix jdt formatter error

Signed-off-by: Nathalie Jonathan <[email protected]>

* Fix file name

Signed-off-by: Nathalie Jonathan <[email protected]>

* Refactor spotless

Signed-off-by: Nathalie Jonathan <[email protected]>

---------

Signed-off-by: Nathalie Jonathan <[email protected]>
@dhrubo-os dhrubo-os dismissed stale reviews from xinyual and b4sjoo via 400f1df September 3, 2025 01:05
@dhrubo-os dhrubo-os temporarily deployed to ml-commons-cicd-env September 3, 2025 01:07 — with GitHub Actions Inactive
@dhrubo-os dhrubo-os temporarily deployed to ml-commons-cicd-env September 3, 2025 01:07 — with GitHub Actions Inactive
@dhrubo-os
Copy link
Collaborator Author

Closing this PR in favor of: #4153

@dhrubo-os dhrubo-os closed this Sep 3, 2025
Copy link

codecov bot commented Sep 3, 2025

Codecov Report

❌ Patch coverage is 91.89189% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.81%. Comparing base (f75ae1a) to head (400f1df).

Files with missing lines Patch % Lines
...RemoteMlCommonsPassthroughPostProcessFunction.java 88.00% 0 Missing and 6 partials ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##             agentic_memory    #4148      +/-   ##
====================================================
- Coverage             81.81%   81.81%   -0.01%     
- Complexity             8847     8866      +19     
====================================================
  Files                   761      762       +1     
  Lines                 38099    38171      +72     
  Branches               4250     4266      +16     
====================================================
+ Hits                  31170    31228      +58     
- Misses                 5109     5111       +2     
- Partials               1820     1832      +12     
Flag Coverage Δ
ml-commons 81.81% <91.89%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants