Skip to content

Conversation

b4sjoo
Copy link
Collaborator

@b4sjoo b4sjoo commented Oct 9, 2025

Description

  1. After this PR user don't need to explicitly prompt llm_result_path anymore, which is error-prone and risky.
  2. With this PR user can just use Claude blueprints uploaded this time and current GPT blueprints to create container without blockers, system_prompt can automatically added to gpt/claude models correctly
  3. All multi-modal object will be supported by their own structure and inferred correctly by LLM
  4. single tool_use/ tool_result object can also be inferred

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Oct 9, 2025

Codecov Report

❌ Patch coverage is 77.60870% with 103 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.20%. Comparing base (cac8ddb) to head (c7af688).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...emorycontainer/memory/MemoryProcessingService.java 72.66% 30 Missing and 11 partials ⚠️
...l/common/utils/message/OpenAIMessageFormatter.java 66.10% 12 Missing and 8 partials ⚠️
...l/common/utils/message/ClaudeMessageFormatter.java 62.00% 12 Missing and 7 partials ⚠️
...search/ml/common/utils/LlmResultPathGenerator.java 86.04% 4 Missing and 8 partials ⚠️
...pensearch/ml/common/utils/ModelInterfaceUtils.java 95.50% 3 Missing and 1 partial ⚠️
.../common/utils/message/MessageFormatterFactory.java 77.77% 4 Missing ⚠️
...ava/org/opensearch/ml/common/utils/IndexUtils.java 66.66% 1 Missing and 1 partial ⚠️
...rycontainer/memory/TransportAddMemoriesAction.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4289      +/-   ##
============================================
+ Coverage     80.16%   80.20%   +0.03%     
- Complexity    10168    10238      +70     
============================================
  Files           854      855       +1     
  Lines         44183    44364     +181     
  Branches       5112     5152      +40     
============================================
+ Hits          35418    35580     +162     
+ Misses         6613     6604       -9     
- Partials       2152     2180      +28     
Flag Coverage Δ
ml-commons 80.20% <77.60%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@b4sjoo b4sjoo had a problem deploying to ml-commons-cicd-env October 9, 2025 16:36 — with GitHub Actions Failure
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env October 9, 2025 16:36 — with GitHub Actions Inactive
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env October 9, 2025 19:51 — with GitHub Actions Inactive
@b4sjoo b4sjoo had a problem deploying to ml-commons-cicd-env October 9, 2025 19:51 — with GitHub Actions Failure
@b4sjoo b4sjoo had a problem deploying to ml-commons-cicd-env October 9, 2025 19:51 — with GitHub Actions Error
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env October 9, 2025 19:51 — with GitHub Actions Inactive
@b4sjoo b4sjoo force-pushed the feature/agentic_memory_refactor branch from 17c0480 to c7af688 Compare October 9, 2025 20:06
@b4sjoo b4sjoo had a problem deploying to ml-commons-cicd-env October 9, 2025 20:10 — with GitHub Actions Failure
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env October 9, 2025 20:10 — with GitHub Actions Inactive
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env October 9, 2025 20:10 — with GitHub Actions Inactive
@b4sjoo b4sjoo had a problem deploying to ml-commons-cicd-env October 9, 2025 20:10 — with GitHub Actions Error
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env October 9, 2025 21:15 — with GitHub Actions Inactive
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env October 9, 2025 21:15 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant