generated from amazon-archives/__template_Custom
-
Notifications
You must be signed in to change notification settings - Fork 183
fix: correctly auto-generated on llm_result_path #4289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
b4sjoo
wants to merge
3
commits into
opensearch-project:main
Choose a base branch
from
b4sjoo:feature/agentic_memory_refactor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: correctly auto-generated on llm_result_path #4289
b4sjoo
wants to merge
3
commits into
opensearch-project:main
from
b4sjoo:feature/agentic_memory_refactor
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4289 +/- ##
============================================
+ Coverage 80.16% 80.20% +0.03%
- Complexity 10168 10238 +70
============================================
Files 854 855 +1
Lines 44183 44364 +181
Branches 5112 5152 +40
============================================
+ Hits 35418 35580 +162
+ Misses 6613 6604 -9
- Partials 2152 2180 +28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…es model automated interface Signed-off-by: Sicheng Song <[email protected]>
Signed-off-by: Sicheng Song <[email protected]>
Signed-off-by: Sicheng Song <[email protected]>
17c0480
to
c7af688
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
llm_result_path
anymore, which is error-prone and risky.system_prompt
can automatically added to gpt/claude models correctlytool_use
/tool_result
object can also be inferredRelated Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.