Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature branch] Add Neural Stats API #1208
[Feature branch] Add Neural Stats API #1208
Changes from 19 commits
19480ae
a1f24f0
064465b
e4abeca
9274a71
e1cb163
282db07
7d08433
df81f11
4677199
8cc6698
24760a5
c15bcff
a8c3d0a
9425021
7ba9dcb
fe8a616
56c2d19
d540f28
3da5765
64032f3
f6fc682
c56a110
73e2228
0734a6a
7b532a5
2e0c119
82504ce
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this declaration to top
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't static fields typically go before instance fields?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even if stats is specified, if there is not matching stats, do we want to return all stats instead of empty?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, currently that's how other stats APIs work, they return all stats if no stats match. I think the reasoning is that invalid stat names are ignored, and when all are ignored then it's treated as a get all.