Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds ZScore Normalization Technique #1224

Merged
merged 7 commits into from
Mar 19, 2025
Merged

Adds ZScore Normalization Technique #1224

merged 7 commits into from
Mar 19, 2025

Conversation

owaiskazi19
Copy link
Member

Description

Adds ZScore Normalization Technique

Related Issues

Resolves #376 and #1209

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added Features Introduces a new unit of functionality that satisfies a requirement hybrid search v3.0.0 v3.0.0 labels Mar 11, 2025
@owaiskazi19 owaiskazi19 force-pushed the zscore branch 5 times, most recently from 252bea9 to bc43a35 Compare March 11, 2025 18:23
@codecov Codecov
Copy link

codecov bot commented Mar 11, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.76%. Comparing base (8abb418) to head (a77218d).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #1224      +/-   ##
============================================
- Coverage     81.89%   81.76%   -0.13%     
+ Complexity     2623     1338    -1285     
============================================
  Files           190       96      -94     
  Lines          8962     4579    -4383     
  Branches       1528      784     -744     
============================================
- Hits           7339     3744    -3595     
+ Misses         1030      533     -497     
+ Partials        593      302     -291

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

vibrantvarun
vibrantvarun reviewed Mar 11, 2025
View reviewed changes
Copy link
Member

@vibrantvarun vibrantvarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completed 1st round of review

martin-gaievski
martin-gaievski reviewed Mar 13, 2025
View reviewed changes
vibrantvarun
vibrantvarun reviewed Mar 14, 2025
View reviewed changes
Copy link
Member

@vibrantvarun vibrantvarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall code looks good. Just few minor comments.

@martin-gaievski
Copy link
Member

Please open a documentation PR for this feature, you don't need to create complete content, at this stage it's mainly for tracking purposes

@owaiskazi19 owaiskazi19 force-pushed the zscore branch 2 times, most recently from b182ecf to 1f42ae8 Compare March 18, 2025 20:59
martin-gaievski
martin-gaievski approved these changes Mar 18, 2025
View reviewed changes
Copy link
Member

@martin-gaievski martin-gaievski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, thanks @owaiskazi19. Please address my comment, it's minor, and we're good.

@owaiskazi19
Copy link
Member Author

Please open a documentation PR for this feature, you don't need to create complete content, at this stage it's mainly for tracking purposes

opensearch-project/documentation-website#9455

vibrantvarun
vibrantvarun reviewed Mar 19, 2025
View reviewed changes
Copy link
Member

@vibrantvarun vibrantvarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but need to resolve merge conflicts.

@vibrantvarun vibrantvarun merged commit f5377c0 into opensearch-project:main Mar 19, 2025
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vibrantvarun vibrantvarun vibrantvarun approved these changes

@martin-gaievski martin-gaievski martin-gaievski approved these changes

@heemin32 heemin32 Awaiting requested review from heemin32 heemin32 is a code owner

@VijayanB VijayanB Awaiting requested review from VijayanB VijayanB is a code owner

@vamshin vamshin Awaiting requested review from vamshin vamshin is a code owner

@jmazanec15 jmazanec15 Awaiting requested review from jmazanec15 jmazanec15 is a code owner

@naveentatikonda naveentatikonda Awaiting requested review from naveentatikonda naveentatikonda is a code owner

@junqiu-lei junqiu-lei Awaiting requested review from junqiu-lei junqiu-lei is a code owner

@sean-zheng-amazon sean-zheng-amazon Awaiting requested review from sean-zheng-amazon sean-zheng-amazon is a code owner

@model-collapse model-collapse Awaiting requested review from model-collapse model-collapse is a code owner

@zane-neo zane-neo Awaiting requested review from zane-neo zane-neo is a code owner

@zhichao-aws zhichao-aws Awaiting requested review from zhichao-aws zhichao-aws is a code owner

@yuye-aws yuye-aws Awaiting requested review from yuye-aws yuye-aws is a code owner

@minalsha minalsha Awaiting requested review from minalsha minalsha is a code owner

@navneet1v navneet1v Awaiting requested review from navneet1v navneet1v is a code owner

Assignees
No one assigned
Labels
Features Introduces a new unit of functionality that satisfies a requirement hybrid search v3.0.0 v3.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add z-score for the normalization processor
4 participants
@owaiskazi19 @martin-gaievski @navneet1v @vibrantvarun