Add semantic field mapper. #1225
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzhangam
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
sean-zheng-amazon,
model-collapse,
zane-neo,
vibrantvarun,
zhichao-aws,
yuye-aws and
minalsha
as code owners
github-actions
bot
added
Enhancements
bzhangam
commented
Mar 11, 2025
bzhangam
commented
Mar 11, 2025
junqiu-lei
reviewed
Mar 11, 2025
src/main/java/org/opensearch/neuralsearch/mapper/SemanticFieldMapper.java
Show resolved
Hide resolved
will-hwang
reviewed
Mar 11, 2025
src/main/java/org/opensearch/neuralsearch/mapper/SemanticFieldMapper.java
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/mapper/SemanticFieldMapper.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/mapper/SemanticFieldMapper.java
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/mapper/SemanticFieldMapper.java
Show resolved
Hide resolved
...ain/java/org/opensearch/neuralsearch/mapper/semanticFieldTypes/SemanticFieldTypeFactory.java
Outdated
Show resolved
Hide resolved
.../java/org/opensearch/neuralsearch/mapper/semanticFieldTypes/SemanticFieldTypeParameters.java
Outdated
Show resolved
Hide resolved
q-andy
reviewed
Mar 13, 2025
src/main/java/org/opensearch/neuralsearch/constants/SemanticFieldConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/mapper/SemanticFieldMapper.java
Outdated
Show resolved
Hide resolved
...ain/java/org/opensearch/neuralsearch/mapper/semanticFieldTypes/SemanticFieldTypeFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/mapper/semanticFieldTypes/SemanticFieldType.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/neuralsearch/mapper/semanticFieldTypes/SemanticFieldTypeTests.java
Outdated
Show resolved
Hide resolved
...java/org/opensearch/neuralsearch/mapper/semanticFieldTypes/SemanticStringFieldTypeTests.java
Outdated
Show resolved
Hide resolved
...main/java/org/opensearch/neuralsearch/mapper/semanticFieldTypes/SemanticNumberFieldType.java
Outdated
Show resolved
Hide resolved
heemin32
reviewed
Mar 14, 2025
src/main/java/org/opensearch/neuralsearch/mapper/SemanticFieldMapper.java
Outdated
Show resolved
Hide resolved
|
|
||
| protected Builder(String name) { | ||
| super(name); | ||
| semanticFieldTypeFactory = new SemanticFieldTypeFactory(); |
There was a problem hiding this comment.
It's better to inject it from outside, and even better if we can make it reusable.
protected Builder(String name, SemanticFieldTypeFactory semanticFieldTypeFactory) {
...
}
.../java/org/opensearch/neuralsearch/mapper/semanticfieldtypes/SemanticFieldTypeParameters.java
Outdated
Show resolved
Hide resolved
heemin32
approved these changes
Mar 18, 2025
Signed-off-by: Bo Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add semantic field mapper to support the semantic field type.
Test will fail until this PR is merged into core.
Related Issues
Resolves #[803]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.