-
Notifications
You must be signed in to change notification settings - Fork 105
Add batch semantic highlighting support #1520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add batch semantic highlighting support #1520
Conversation
8e8c0f2
to
006d54a
Compare
Not yet add integ test since the batch inference only support with remote model, we could run remote model integ test by one of the options:
|
src/main/java/org/opensearch/neuralsearch/highlight/SemanticHighlightingResponseProcessor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/processor/util/ProcessorUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/highlight/SemanticHighlightingResponseProcessor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/highlight/SemanticHighlightingResponseProcessor.java
Outdated
Show resolved
Hide resolved
We could still test single highlighting functionality with local model? |
src/main/java/org/opensearch/neuralsearch/highlight/SemanticHighlightingResponseProcessor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/highlight/SemanticHighlightingResponseProcessor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/highlight/SemanticHighlightingResponseProcessor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/processor/util/ProcessorUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/ml/MLCommonsClientAccessor.java
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/highlight/SemanticHighlightingResponseProcessor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/highlight/SemanticHighlightingResponseProcessor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/highlight/SemanticHighlightingResponseProcessor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/highlight/SemanticHighlightingResponseProcessor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/highlight/SemanticHighlightingResponseProcessor.java
Outdated
Show resolved
Hide resolved
Yes, we can still test single highlighting functionality with local model, while the other main function are from batch ability. |
src/main/java/org/opensearch/neuralsearch/ml/MLCommonsClientAccessor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/ml/MLCommonsClientAccessor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/ml/MLCommonsClientAccessor.java
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/processor/util/ProcessorUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/processor/util/ProcessorUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/highlight/SemanticHighlightingResponseProcessor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/highlight/SemanticHighlightingResponseProcessor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/highlight/SemanticHighlightingResponseProcessor.java
Outdated
Show resolved
Hide resolved
...java/org/opensearch/neuralsearch/highlight/SemanticHighlightingResponseProcessorFactory.java
Outdated
Show resolved
Hide resolved
…ompatibility for local and remote models Signed-off-by: Junqiu Lei <[email protected]>
Signed-off-by: Junqiu Lei <[email protected]>
Signed-off-by: Junqiu Lei <[email protected]>
…c pipeline detection Signed-off-by: Junqiu Lei <[email protected]>
Signed-off-by: Junqiu Lei <[email protected]>
…e it on github remote model CI Signed-off-by: Junqiu Lei <[email protected]>
Signed-off-by: Junqiu Lei <[email protected]>
Signed-off-by: Junqiu Lei <[email protected]>
Signed-off-by: Junqiu Lei <[email protected]>
Signed-off-by: Junqiu Lei <[email protected]>
Signed-off-by: Junqiu Lei <[email protected]>
Signed-off-by: Junqiu Lei <[email protected]>
Signed-off-by: Junqiu Lei <[email protected]>
Signed-off-by: Junqiu Lei <[email protected]>
Signed-off-by: Junqiu Lei <[email protected]>
Signed-off-by: Junqiu Lei <[email protected]>
Signed-off-by: Junqiu Lei <[email protected]>
Signed-off-by: Junqiu Lei <[email protected]>
Signed-off-by: Junqiu Lei <[email protected]>
Signed-off-by: Junqiu Lei <[email protected]>
Signed-off-by: Junqiu Lei <[email protected]>
Signed-off-by: Junqiu Lei <[email protected]>
Signed-off-by: Junqiu Lei <[email protected]>
Signed-off-by: Junqiu Lei <[email protected]>
Signed-off-by: Junqiu Lei <[email protected]>
65b1466
to
1cd5b77
Compare
LGTM |
Description
This PR adds batch processing to semantic highlighting while keeping everything backward compatible.
Highlight API
Processing Flow
Remote model integration test
This PR also introduced torch serve framework for remote model integration tests. The framework is extensible to host other models(such as embedding model, llms) as well. Example run at here, updated in DEVELOPER_GUIDE.md as well.
Related Issues
Resolves #1516
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.