-
Notifications
You must be signed in to change notification settings - Fork 78
Fix Search API schema #860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Karen Xu <[email protected]>
Signed-off-by: Karen Xu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a test please that uses verbose_pipeline
.
@@ -53,7 +53,7 @@ Set up an OpenSearch cluster with Docker: | |||
```bash | |||
export OPENSEARCH_PASSWORD=<<your_password>> | |||
cd tests/default | |||
docker compose up -d | |||
docker-compose up -d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is incorrect, old version, https://docs.docker.com/compose/releases/migrate/.
properties: | ||
value_type: | ||
description: |- | ||
Specifies the types of values used for filtering. Valid values are default and bitmap. If omitted, the value defaults to default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we support default: default
? Either way either:
Specifies the types of values used for filtering. Valid values are default and bitmap. If omitted, the value defaults to default. | |
Specifies the types of values used for filtering. |
or
Specifies the types of values used for filtering. Valid values are default and bitmap. If omitted, the value defaults to default. | |
Specifies the types of values used for filtering. Valid values are `default` and `bitmap`. Default is `default`. |
Changes AnalysisCommit SHA: 7dbb616 API ChangesSummary
ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/14388002344/artifacts/2930667457 API Coverage
|
Description
ExplanationDetail
. The type is just Explanationstore
field was added in https://github.com/opensearch-project/OpenSearch/pull/14774/files to TermsLookup.ValueType
was added in 2.17 per https://opensearch.org/docs/latest/query-dsl/term/terms/#bitmap-filteringIssues Resolved
General spec fixes, contributing to accuracy of the Search Protobufs:
opensearch-project/OpenSearch#16783
opensearch-project/opensearch-protobufs#30
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.