Skip to content

Fix BuildManifestBuilder.append_artifact to safely initialize artifact lists #5525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix BuildManifestBuilder.append_artifact to safely initialize artifact lists #5525

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/build_workflow/build_recorder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,10 +86,9 @@ def append_component(self, name: str, version: str, repository_url: str, ref: st

def append_artifact(self, component: str, type: str, path: str) -> None:
artifacts = self.components_hash[component]["artifacts"]
list = artifacts.get(type, [])
if len(list) == 0:
artifacts[type] = list
list.append(path)
if type not in artifacts or not isinstance(artifacts[type], list):
artifacts[type] = []
artifacts[type].append(path)

def to_manifest(self) -> 'BuildManifest':
# The build manifest expects `components` to be a list, not a hash, so we need to munge things a bit
Expand Down