-
Notifications
You must be signed in to change notification settings - Fork 124
Add action to refresh search analyzers to ISM plugin client #686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add action to refresh search analyzers to ISM plugin client #686
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #686 +/- ##
==========================================
+ Coverage 57.29% 60.37% +3.08%
==========================================
Files 315 379 +64
Lines 9823 11738 +1915
==========================================
+ Hits 5628 7087 +1459
- Misses 2902 3212 +310
- Partials 1293 1439 +146
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
75b74fe
to
3e4dd8c
Compare
Test failures look unrelated to my changes. I think integration tests are a bit flaky, but I have no permission to restart the failed jobs |
@dblock Hey, this pull request has been waiting for a bit. Can I have some feedback on this? I would love to see it merged and released 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Only the naming of Reload should be changed to Refresh
3e4dd8c
to
5824c4c
Compare
I pushed the requested changes, but I'm not sure what's going on with the linter. To me, everything looks correct 🤔 |
The linter should hopefully work again once #740 got merged and you rebase it. |
My MR got merged. Please rebase and check if the issue still persists. |
Signed-off-by: Stefano Arlandini <[email protected]>
5824c4c
to
9d752b2
Compare
We're good to go, but there are a few flaky tests that need a second run 🚀 |
Description
The changes in this merge request focus on adding support for refreshing the search analyzers to the client of the ISM plugin.
Issues Resolved
Closes #678
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.