Support KnnQuery's method_parameters and rescore properties
#1407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xtansia
requested review from
reta,
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda,
saratvemulapalli and
VachaShah
as code owners
Xtansia
force-pushed
the
feat/knn-query
branch
2 times, most recently
from
25f0e41 to
717a7bf
Compare
Signed-off-by: Thomas Farr <[email protected]>
Xtansia
force-pushed
the
feat/knn-query
branch
from
717a7bf to
e019335
Compare
reta
approved these changes
Feb 3, 2025
|
Thanks for raising this PR. Can we also include this property too? |
Signed-off-by: Thomas Farr <[email protected]>
Have added it |
VijayanB
approved these changes
Feb 4, 2025
|
Can this be merged and add new release artifact? Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support KnnQuery's
method_parametersandrescoreproperties. This is manually implemented feature to2.xas it can not be generated or auto-backported frommainwithout introducing breaking changes. There will be follow up PRs to fix the spec and regenerate the class inmain.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.