Support normalizer on wildcard field
#1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukas-krecan
requested review from
reta,
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda,
saratvemulapalli,
VachaShah and
Xtansia
as code owners
Xtansia
requested changes
Mar 19, 2025
There was a problem hiding this comment.
Thanks for contributing this @lukas-krecan, have made just a couple comments for things that will need addressing.
Additionally please sign off your commits for DCO, see here for more info: https://github.com/opensearch-project/opensearch-java/pull/1489/checks?check_run_id=39066447600
lukas-krecan
force-pushed
the
wc-normalizer
branch
2 times, most recently
from
96988a6 to
53d9b56
Compare
Resolves opensearch-project#1153 Signed-off-by: Lukáš Křečan <[email protected]> Signed-off-by: Lukas Krecan <[email protected]>
lukas-krecan
force-pushed
the
wc-normalizer
branch
from
53d9b56 to
4ba104f
Compare
Xtansia
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1153
Description
Support
normalizeron wildcard fieldIssues Resolved
#1153
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.