Support Callable as http_auth type in AIOHttpConnection

[superleesa]

Description

Support Callable http_auth in AIOHttpConnection, similar to how Urllib3HttpConnection handles http_auth.

Reference

Urllib3HttpConnection handles Callable http_auth.

opensearch-py/opensearchpy/connection/http_urllib3.py

Lines 141 to 149 in 7336f51

	if self.http_auth is not None:
	if isinstance(self.http_auth, Callable): # type: ignore
	pass
	elif isinstance(self.http_auth, (tuple, list)):
	self.headers.update(
	urllib3.make_headers(basic_auth=":".join(http_auth))
	)
	else:
	self.headers.update(urllib3.make_headers(basic_auth=http_auth))

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov]

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.38%. Comparing base (ba715b9) to head (f06d442).
Report is 82 commits behind head on main.

Files with missing lines	Patch %	Lines
opensearchpy/_async/http_aiohttp.py	75.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #892      +/-   ##
==========================================
- Coverage   71.95%   70.38%   -1.57%     
==========================================
  Files          91      125      +34     
  Lines        8001     9294    +1293     
==========================================
+ Hits         5757     6542     +785     
- Misses       2244     2752     +508     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dblock]

I like this, needs tests and a CHANGELOG.

[superleesa]

@dblock
Hi! I was reading the codebase to add tests, but noticed that AsyncHTTPConnection already supports Callable http_auth. Why is this not the default connection in AsyncTransport? ref:

opensearch-py/opensearchpy/_async/transport.py

Line 59 in 7336f51

DEFAULT_CONNECTION_CLASS = AIOHttpConnection

Another thing is, the code for AsyncHTTPConnection and AIOHTTPConnection seem very similar, with only differences being 1) supports Callable http_auth, 2) support setting trust_env, 3) uses yarl. Most parts seem copied and pasted. Are there any reasons for this? If not, I thought maybe I could port most parts of the code in AsyncHTTPConnection to AIOHTTPConnection for maintainability.

[dblock]

@superleesa The reasons are likely completely historical, feel free to do the right thing (TM) and fix this.