Add support to test against multiple versions of OpenSearch#62
Conversation
Signed-off-by: Vacha Shah <vachshah@amazon.com>
Signed-off-by: Vacha Shah <vachshah@amazon.com>
saratvemulapalli
left a comment
saratvemulapalli
left a comment
There was a problem hiding this comment.
Changes look good to me. Thanks @VachaShah !
Dropped a minor comment.
| fail-fast: false | ||
| matrix: | ||
| cluster-version: [ "1.0.0", "1.0.1", "1.1.0", "1.2.0", "1.2.1", "1.2.2", "1.2.3", "1.2.4", "1.3.0", "1.3.1" ] | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
Are we expecting clients to work on multiple platforms, cpu architectures?
I am curious how this works for clients. Are there any platform specific code in clients?
As a developer I would like to have these clients tested and validated atleast in the popular platforms.
There was a problem hiding this comment.
I haven't yet come across platform specific code in the clients, we can definitely create an issue in opensearch-clients to add this testing as a feature.
There was a problem hiding this comment.
i believe it is interpreted at run time. But i like the idea of including strategy to cover mac/linux/windows to be proactive in all our clients.
There was a problem hiding this comment.
Sure, I'll open an issue. opensearch-project/opensearch-clients#18
3 participants
Description
Adding support to run tests against multiple versions of OpenSearch in the CI. I separated out the
compatibility.ymlsince the matrix was becoming huge in themain.ymlwith multiple ruby versions.Issues Resolved
#56
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.