Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move end-to-end tests to a separate workflow #1052

Merged
merged 3 commits into from
Feb 15, 2025
Merged

Move end-to-end tests to a separate workflow #1052

merged 3 commits into from
Feb 15, 2025

Conversation

normanj-bitquill
Copy link
Contributor

Description

Move the end-to-end tests to a separate workflow. Also lowered the timeout for starting the docker cluster to 20 minutes.

Related Issues

None

Check List

  • Updated documentation (docs/ppl-lang/README.md)
  • Implemented unit tests
  • Implemented tests for combination with other commands
  • New added source code should include a copyright header
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@normanj-bitquill
Copy link
Contributor Author

@YANG-DB I think that the failure is from this commit. It is reproducible. Start the docker test environment and add the OpenSearch index people from the End-to-End tests. The Spark PPL query query_177 is the failing query. If you run it in Spark shell on the spark node, it will fail.

4783f08#diff-d0ff060db8a870b1f95c43b6c78e981fd3a4903a1ec627c987a32a2159bb30f9

The generated query ends up with must_not not having a value.

https://github.com/opensearch-project/opensearch-spark/blob/main/flint-spark-integration/src/main/scala/org/apache/spark/sql/flint/storage/FlintQueryCompiler.scala#L93

@normanj-bitquill
Renamed the end-to-end step
387a0a9 
Signed-off-by: Norman Jordan <[email protected]>
@normanj-bitquill
Copy link
Contributor Author

@penghuo See my comment above about a possible regression.

@penghuo
Copy link
Collaborator

penghuo commented Feb 15, 2025

@penghuo See my comment above about a possible regression.

how do you identify the failed query from log. any doc i can learn.

penghuo
penghuo approved these changes Feb 15, 2025
View reviewed changes
Copy link
Collaborator

@penghuo penghuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@penghuo penghuo merged commit 0dc2d2a into opensearch-project:main Feb 15, 2025
4 of 5 checks passed
@normanj-bitquill
Copy link
Contributor Author

@penghuo Download the test-artifacts artifact for the failed CI run. The Zip file contains a directory named e2e-test. That is an HTML report, so the index.html file can be opened in a browser. Click on the EndToEndITSuite. There are 4 tests. Click on the Show Details link for the failed test. Look for lines beginning with Query = and Base Filename =

@ykmr1224
Copy link
Collaborator

@normanj-bitquill Please backport to 0.x if it is not a breaking change. We started similar branching as sql repository. (ref)

@ykmr1224 ykmr1224 added the backport 0.x Backport to 0.x branch (stable branch) label Feb 25, 2025
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 25, 2025
@github-actions
Move end-to-end tests to a separate workflow (#1052)
fda450d 
Signed-off-by: Norman Jordan <[email protected]>
(cherry picked from commit 0dc2d2a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Feb 25, 2025
Merged
ykmr1224 pushed a commit that referenced this pull request Feb 25, 2025
@opensearch-trigger-bot @github-actions
Move end-to-end tests to a separate workflow (#1052) (#1069)
58ed996 
(cherry picked from commit 0dc2d2a)

Signed-off-by: Norman Jordan <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@penghuo penghuo penghuo approved these changes

@YANG-DB YANG-DB YANG-DB approved these changes

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

@kaituo kaituo Awaiting requested review from kaituo kaituo is a code owner

@noCharger noCharger Awaiting requested review from noCharger noCharger is a code owner

@LantaoJin LantaoJin Awaiting requested review from LantaoJin LantaoJin is a code owner

@ykmr1224 ykmr1224 Awaiting requested review from ykmr1224 ykmr1224 is a code owner

Assignees
No one assigned
Labels
backport 0.x Backport to 0.x branch (stable branch)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@normanj-bitquill @penghuo @ykmr1224 @YANG-DB