[Enhancement] Unify all PPL functions in BuiltinFunctionName #1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Heng Qian <[email protected]>
qianheng-aws
requested review from
dai-chen,
mengweieric,
penghuo,
seankao-az,
anirudha,
kaituo,
YANG-DB,
noCharger,
LantaoJin and
ykmr1224
as code owners
Signed-off-by: Heng Qian <[email protected]>
LantaoJin
approved these changes
Feb 20, 2025
penghuo
reviewed
Feb 20, 2025
| @@ -75,6 +82,14 @@ | |||
| import static org.opensearch.sql.ppl.utils.DataTypeTransformer.seq; | |||
| import static scala.Option.empty; | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Thanks for improving the javadoc.
penghuo
reviewed
Feb 20, 2025
YANG-DB
approved these changes
Feb 20, 2025
Signed-off-by: Heng Qian <[email protected]>
e2e IT retry successfully without any code change. Seems a flakey failure. I don't see any failure except |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 21, 2025
* [Enhancement] Unify all PPL functions in BuiltinFunctionName Signed-off-by: Heng Qian <[email protected]> * Fix UT Signed-off-by: Heng Qian <[email protected]> * Tiny change in doc Signed-off-by: Heng Qian <[email protected]> --------- Signed-off-by: Heng Qian <[email protected]> (cherry picked from commit 7c87378) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
LantaoJin
pushed a commit
that referenced
this pull request
Feb 24, 2025
…1064) * [Enhancement] Unify all PPL functions in BuiltinFunctionName * Fix UT * Tiny change in doc --------- (cherry picked from commit 7c87378) Signed-off-by: Heng Qian <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unify all PPL functions in BuiltinFunctionName. This PR includes change:
BuiltinFunctionName, that place should be the single of truth to maintain all PPL built-in functions.SerializableUdf::visitchange to use function enumerator as its switch key instead of string.PPL_TO_SPARK_UDF_MAPPINGinBuiltinFunctionTransformerto do transformation of PPL built-in function to Spark UDF we implemented in this project.Related Issues
Resolves: #1051
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.