Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alias could be wrapped with backticks in RENAME and other commands #1066

Merged
merged 2 commits into from
Feb 25, 2025
Merged

Alias could be wrapped with backticks in RENAME and other commands #1066

merged 2 commits into from
Feb 25, 2025

Conversation

LantaoJin
Copy link
Member

@LantaoJin LantaoJin commented Feb 24, 2025 •
edited
Loading

Description

Details in #1063

Related Issues

Resolves #1063

Check List

  • Updated documentation (docs/ppl-lang/README.md)
  • Implemented unit tests
  • Implemented tests for combination with other commands
  • New added source code should include a copyright header
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@LantaoJin LantaoJin added the backport 0.x Backport to 0.x branch (stable branch) label Feb 24, 2025
@LantaoJin LantaoJin marked this pull request as ready for review February 24, 2025 03:42
@LantaoJin
Copy link
Member Author

cc @YANG-DB @dai-chen @ykmr1224 and @qianheng-aws

@LantaoJin
UT refactor
ae76067 
Signed-off-by: Lantao Jin <[email protected]>
@LantaoJin LantaoJin merged commit b9a0dc5 into opensearch-project:main Feb 25, 2025
5 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 25, 2025
@github-actions
Alias could be wrapped with backticks in RENAME and other commands (#…
b59bbb4 
…1066)

(cherry picked from commit b9a0dc5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Feb 25, 2025
Merged
LantaoJin pushed a commit that referenced this pull request Feb 26, 2025
@opensearch-trigger-bot @github-actions
Alias could be wrapped with backticks in RENAME and other commands (#…
6ff77d9 
…1066) (#1070)

(cherry picked from commit b9a0dc5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@penghuo penghuo penghuo approved these changes

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

@kaituo kaituo Awaiting requested review from kaituo kaituo is a code owner

@YANG-DB YANG-DB Awaiting requested review from YANG-DB YANG-DB is a code owner

@noCharger noCharger Awaiting requested review from noCharger noCharger is a code owner

@ykmr1224 ykmr1224 Awaiting requested review from ykmr1224 ykmr1224 is a code owner

Assignees
No one assigned
Labels
backport 0.x Backport to 0.x branch (stable branch)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] RENAME AS with backticked string mistakenly treats the backticks as a part of new field name
2 participants
@LantaoJin @penghuo