Sanitize sparkUpgrade error message #1077
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Siri Teja Gaddameedi <[email protected]>
Siritejagaddameedi
requested review from
dai-chen,
mengweieric,
penghuo,
seankao-az,
anirudha,
kaituo,
YANG-DB,
noCharger,
LantaoJin and
ykmr1224
as code owners
dai-chen
reviewed
Mar 4, 2025
noCharger
requested changes
Mar 7, 2025
Comment on lines
+157
to
+161
| case e: SparkUpgradeException => | ||
| incrementCounter(MetricConstants.RESULT_WRITER_FAILED_METRIC) | ||
| throwableHandler.recordThrowable( | ||
| s"Failed to write to result. Cause='${sanitizeSparkUpgradeErrorMessage(e.getMessage)}'", | ||
| e) |
There was a problem hiding this comment.
https://github.com/opensearch-project/opensearch-spark/blob/main/spark-sql-application/src/main/scala/org/apache/spark/sql/FlintJobExecutor.scala#L445 should be the start point handling query exception.
There was a problem hiding this comment.
Here the usecase being having to sanitize/trim the error message, where as handleQueryException handles various exceptions and adds a prefix to the error message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sanitize sparkUpgrade error message
We noticed a when user enter incorrect query related to date time formatter, spark throws sparkUpgradeException. This error message contains sparkUpgrade related text and we are sanitizing the error message
Related Issues
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.