Skip to content

[Backport 2.19] [Backport 2.x] Bug Fix - Placeholder ${metric} Not Replaced with Actual Metric Type #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2025
Merged

[Backport 2.19] [Backport 2.x] Bug Fix - Placeholder ${metric} Not Replaced with Actual Metric Type #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion public/pages/Configuration/Configuration.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ const Configuration = ({
listItems={[
{
title: <h3>Enabled</h3>,
description: 'Enable/disable top N query monitoring by ${metric}.',
description: `Enable/disable top N query monitoring by ${metric}.`,
},
]}
/>
Expand Down
4 changes: 2 additions & 2 deletions public/pages/Configuration/__snapshots__/Configuration.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ exports[`Configuration Component renders with default settings: should match def
<dd
class="euiDescriptionList__description"
>
Enable/disable top N query monitoring by \${metric}.
Enable/disable top N query monitoring by latency.
</dd>
</dl>
</div>
Expand Down Expand Up @@ -1189,7 +1189,7 @@ exports[`Configuration Component updates state when toggling metrics and enables
<dd
class="euiDescriptionList__description"
>
Enable/disable top N query monitoring by \${metric}.
Enable/disable top N query monitoring by cpu.
</dd>
</dl>
</div>
Expand Down
Loading