Fix bugs in UI and refactor types and interfaces #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansjcy
requested review from
jainankitk,
deshsidd and
dzane17
as code owners
|
This has become a large PR with multiple purposes, I'm gonna move it to several smaller ones for better review experience. |
ansjcy
changed the title
ansjcy
force-pushed
the
fix-measurements-render-after-grouping-changes
branch
3 times, most recently
from
6170a3d to
f95ecd4
Compare
Signed-off-by: Chenyang Ji <[email protected]>
ansjcy
force-pushed
the
fix-measurements-render-after-grouping-changes
branch
from
f95ecd4 to
094e631
Compare
|
LGTM |
deshsidd
approved these changes
Sep 11, 2024
dzane17
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fix the bugs in the stats render function caused by the grouping changes. More specifically:
measurements.latency?.number.Issues Resolved
Related to #11
Results
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.