Add version-aware settings support #407
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KishoreKicha14
requested review from
ansjcy,
deshsidd,
dzane17 and
jainankitk
as code owners
KishoreKicha14
force-pushed
the
datasource-update-qi
branch
6 times, most recently
from
ad46231 to
f14b57d
Compare
added 8 commits
October 22, 2025 19:58
Signed-off-by: Kishore Kumaar Natarajan <[email protected]>
Signed-off-by: Kishore Kumaar Natarajan <[email protected]>
Signed-off-by: Kishore Kumaar Natarajan <[email protected]>
Signed-off-by: Kishore Kumaar Natarajan <[email protected]>
Signed-off-by: Kishore Kumaar Natarajan <[email protected]>
Signed-off-by: Kishore Kumaar Natarajan <[email protected]>
Signed-off-by: Kishore Kumaar Natarajan <[email protected]>
Signed-off-by: Kishore Kumaar Natarajan <[email protected]>
KishoreKicha14
force-pushed
the
datasource-update-qi
branch
from
f160e16 to
2580790
Compare
added 3 commits
October 23, 2025 00:56
Signed-off-by: Kishore Kumaar Natarajan <[email protected]>
Signed-off-by: Kishore Kumaar Natarajan <[email protected]>
Signed-off-by: Kishore Kumaar Natarajan <[email protected]>
KishoreKicha14
force-pushed
the
datasource-update-qi
branch
from
afde4d3 to
ca58a52
Compare
Signed-off-by: Kishore Kumaar Natarajan <[email protected]>
ansjcy
reviewed
Oct 24, 2025
common/constants.ts
Outdated
| export const WLM_CONFIG: Readonly<ConfigSchema['wlm']> = Object.freeze({ ...DEFAULT_CONFIG.wlm }); | ||
|
|
||
| // Version constants | ||
| export const VERSION_3_1 = { major: 3, minor: 1 }; |
There was a problem hiding this comment.
Let's make them more type safe, like
interface Version {
major: number;
minor: number;
patch?: number;
}
export const VERSIONS = {
2_19: { major: 2, minor: 19 } as Version,
...
}
There was a problem hiding this comment.
Removed because logic change in version-ulits.ts
public/service.ts
Outdated
|
|
||
| export const [getCore, setCore] = createGetterSetter<CoreStart>('Core'); | ||
|
|
||
| export const [getRouteService, setRouteService] = createGetterSetter<RouteService>(''); |
There was a problem hiding this comment.
why ''? This could make debugging difficult based on https://github.com/opensearch-project/OpenSearch-Dashboards/blob/e5af133ac3b2f210f115a5cf6f74c88bb9bf545b/src/plugins/opensearch_dashboards_utils/common/create_getter_setter.ts#L38
public/utils/version-utils.ts
Outdated
| return cachedVersion; | ||
| }; | ||
|
|
||
| const compareVersion = ( |
There was a problem hiding this comment.
Can we reuse semver? that should be the standard osd library to check the versions. I understand you need to consider the snapshot case, you can still build on top of that library instead of rewriting this whole library.
There was a problem hiding this comment.
There was a problem hiding this comment.
reused semver
ansjcy
reviewed
Oct 24, 2025
| } catch (error) { | ||
| console.error('Failed to fetch data source version:', error); | ||
| if (!isComponentUnmounted) { | ||
| setShowLiveQueries(true); |
There was a problem hiding this comment.
If there's error, should the default value be true?
added 2 commits
October 24, 2025 17:31
Signed-off-by: Kishore Kumaar Natarajan <[email protected]>
Signed-off-by: Kishore Kumaar Natarajan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements version-specific handling for query insights settings to support API structure changes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.