Skip to content

Version decoupling and tests for MDS #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

ansjcy
Copy link
Member

@ansjcy ansjcy commented Jan 27, 2025

Description

Support version decoupling and added unit tests for MDS

  • Add a cluster dstest with expected version
  • Add another cluster with lower version
  • Only dstest is shown on the selector
image

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ansjcy ansjcy force-pushed the version-decoupling-mds branch from 4c0ce5c to fa7f16c Compare January 27, 2025 23:36
Copy link
Collaborator

@deshsidd deshsidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall

Copy link
Contributor

@derek-ho derek-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ansjcy ansjcy merged commit 53684b1 into opensearch-project:main Jan 28, 2025
9 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/query-insights-dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/query-insights-dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-74-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 53684b1b494b9d4772d88385f148dfa289e0d549
# Push it to GitHub
git push --set-upstream origin backport/backport-74-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/query-insights-dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-74-to-2.x.

ansjcy added a commit to ansjcy/query-insights-dashboards that referenced this pull request Jan 28, 2025
ansjcy added a commit to ansjcy/query-insights-dashboards that referenced this pull request Jan 28, 2025
dzane17 pushed a commit that referenced this pull request Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants