fix sorting on top n queries table #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chenyang Ji <[email protected]>
deshsidd
approved these changes
Feb 1, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 1, 2025
Signed-off-by: Chenyang Ji <[email protected]> (cherry picked from commit 8a1f040) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 1, 2025
Signed-off-by: Chenyang Ji <[email protected]> (cherry picked from commit 8a1f040) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ansjcy
pushed a commit
that referenced
this pull request
Feb 1, 2025
(cherry picked from commit 8a1f040) Signed-off-by: Chenyang Ji <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ansjcy
pushed a commit
that referenced
this pull request
Feb 1, 2025
(cherry picked from commit 8a1f040) Signed-off-by: Chenyang Ji <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
KishoreKicha14
pushed a commit
to KishoreKicha14/query-insights-dashboards
that referenced
this pull request
Feb 12, 2025
Signed-off-by: Chenyang Ji <[email protected]>
ansjcy
added a commit
that referenced
this pull request
Feb 14, 2025
* Ensure constants and utils are under common (#88) Signed-off-by: Chenyang Ji <[email protected]> * 2.19 release notes (#90) (#91) (cherry picked from commit 0a7e9a9) Signed-off-by: David Zane <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix sorting on top n queries table (#98) (#100) (cherry picked from commit 8a1f040) Signed-off-by: Chenyang Ji <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Increment version to 2.19.0.0 Signed-off-by: opensearch-ci-bot <[email protected]> --------- Signed-off-by: Chenyang Ji <[email protected]> Signed-off-by: David Zane <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: opensearch-ci-bot <[email protected]> Co-authored-by: Chenyang Ji <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-ci-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The sorting on top queries is not working, fixed it by using correct fields and number type as sort key
Testing
Issues Resolved
Closes #97
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.