Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce LocalIndexReader size to 50 #281

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

dzane17
Copy link
Collaborator

@dzane17 dzane17 commented Mar 17, 2025

Description

Limit the number of Top N queries that can be fetched from the local index.

Issues Resolved

Related to opensearch-project/query-insights-dashboards#105

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dzane17 dzane17 marked this pull request as ready for review March 17, 2025 22:25
Signed-off-by: David Zane <davizane@amazon.com>
@dzane17 dzane17 changed the title Reduce MAX_TOP_N_INDEX_READ_SIZE to 50 Reduce LocalIndexReader size to 50 Mar 18, 2025
@ansjcy ansjcy merged commit a876495 into opensearch-project:main Mar 18, 2025
15 checks passed
@dzane17 dzane17 deleted the max-results branch March 18, 2025 20:47
@opensearch-trigger-bot
Copy link

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/query-insights/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/query-insights/backport-2.x
# Create a new branch
git switch --create backport/backport-281-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a87649568773fb3f03daaa221fc740171892fdef
# Push it to GitHub
git push --set-upstream origin backport/backport-281-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/query-insights/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-281-to-2.x.

@opensearch-trigger-bot
Copy link

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/query-insights/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/query-insights/backport-2.x
# Create a new branch
git switch --create backport/backport-281-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a87649568773fb3f03daaa221fc740171892fdef
# Push it to GitHub
git push --set-upstream origin backport/backport-281-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/query-insights/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-281-to-2.x.

dzane17 added a commit to dzane17/query-insights that referenced this pull request Mar 18, 2025
…rch-project#281)

Signed-off-by: David Zane <davizane@amazon.com>
(cherry picked from commit a876495)
dzane17 added a commit to dzane17/query-insights that referenced this pull request Mar 18, 2025
…rch-project#281)

Signed-off-by: David Zane <davizane@amazon.com>
(cherry picked from commit a876495)
dzane17 added a commit that referenced this pull request Mar 18, 2025
…282)

Signed-off-by: David Zane <davizane@amazon.com>
(cherry picked from commit a876495)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 18, 2025
…282)

Signed-off-by: David Zane <davizane@amazon.com>
(cherry picked from commit a876495)
(cherry picked from commit 434b4f1)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dzane17 pushed a commit that referenced this pull request Mar 18, 2025
KishoreKicha14 pushed a commit to KishoreKicha14/query-insights that referenced this pull request Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants