Skip to content

Increase group it retries to 20 [draft] #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Increase group it retries to 20 [draft] #461

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...org/opensearch/plugin/insights/core/service/grouper/MinMaxQueryGrouperBySimilarityIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,8 @@ private void validateGroups(int... expectedGroupSizes) throws IOException, Inter
Thread.sleep(QueryInsightsSettings.QUERY_RECORD_QUEUE_DRAIN_INTERVAL.millis());

List<Map<String, Object>> topQueries = null;
// run ten times to make sure the records are drained to the top queries services
for (int i = 0; i < 10; i++) {
// run twenty times to make sure the records are drained to the top queries services
for (int i = 0; i < 20; i++) {
// Parse the response to validate group structure
Request request = new Request("GET", "/_insights/top_queries?type=latency");
Response response = client().performRequest(request);
Expand Down Expand Up @@ -175,12 +175,12 @@ private void validateGroups(int... expectedGroupSizes) throws IOException, Inter
return;
}

if (i < 9) {
if (i < 19) {
Thread.sleep(QueryInsightsSettings.QUERY_RECORD_QUEUE_DRAIN_INTERVAL.millis());
}
}
fail(
"Failed to validate groups after 10 attempts. Expected groups: "
"Failed to validate groups after 20 attempts. Expected groups: "
+ Arrays.toString(expectedGroupSizes)
+ ", but got: "
+ (topQueries != null ? topQueries.size() : "null")
Expand Down
Loading