-
Notifications
You must be signed in to change notification settings - Fork 7
Add API handlers and API Docker image #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Rohan Chitale <[email protected]>
One comment with memory management. We might end up subtracting less and an incorrect request acceptance by the request queue would throw an out of memory error during the index build process |
The memory estimations are already pretty rough - the formula we're using in |
…y, and prevent eviction of in progress tasks Signed-off-by: Rohan Chitale <[email protected]>
Signed-off-by: Rohan Chitale <[email protected]>
Will add instructions for how to configure and run the API handler once this PR #46 is merged. Basically, i will condense whats talked about here opensearch-project/k-NN#2545 into easy to read instructions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will make a second pass on the tests later, but the source code LGTM so approving
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Initial implementation of Remote Vector Index Builder API handlers. The API handler is a Docker image, built from the base Core image. It contains the out the box functionality to integrate Faiss GPU accelerated index building with the k-NN vector engine.
Issues Resolved
Closes #42
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.