Increase the minimum doc count to 5 #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navneet1v
reviewed
Apr 14, 2025
remote_vector_index_builder/core/common/models/index_build_parameters.py
Show resolved
Hide resolved
Signed-off-by: Rohan Chitale <[email protected]>
rchitale7
force-pushed
the
doc_count_fix
branch
from
75a385f to
d8f2f81
Compare
rchitale7
requested review from
Rajrahane,
yigithub,
vamshin,
jed326,
owenhalpert and
neetikasinghal
as code owners
|
@rchitale7 is the branch properly rebased. The number of changes this small change has introduced seems to be pretty high. |
|
@navneet1v Yeah its rebased, I refactored some of the unit tests so thats why theres a lot of changes. Just wanted to clean things up/make tests more clear |
navneet1v
approved these changes
Apr 14, 2025
Please try to mention this in description, this will help reviewers. :) |
jed326
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During integration testing, we observed that CAGRA would fail to build an index when the doc count was 1, 3 or 4. Specifically, the
copyTomethod used to convert the GPU index to CPU index would hang. This would cause certain kNN integration tests to fail - see #31 and #30. We tested up to having 23,000 docs, and did not see this issue with any other doc count. So, I believe it is sufficient to raise the minimum doc count threshold to 5, to prevent this issue from happening.I also refactored a lot of the unit tests to make testing these types of changes easier in the future
Issues Resolved
Resolves #31 and #30.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.