Add publish core image step as a dependency to publish api image step #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rohan Chitale <[email protected]>
rchitale7
requested review from
Rajrahane,
navneet1v,
yigithub,
vamshin,
jed326,
owenhalpert and
neetikasinghal
as code owners
|
@rchitale7 anything pending on this PR? |
|
@navneet1v Nope this one is good to be merged. It fixes a bug in our CIs |
jed326
approved these changes
Apr 15, 2025
Rajrahane
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
publish_remote_core_image.ymlworkflow runs whenever there's a change in thecore/folder. When that happens, a newcoreimage is published to opensearch staging. Then, since theapiimage depends on certaincorelibraries, a newapiimage is also published to opensearch staging. This change ensures that thecoreimage is first published to opensearch staging, before being used as the base image for theapiimage docker build. Previously, it was possible for thecoreimage publish to happen after theapiimage publish.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.