Remove direct reference to Job-Scheduler Lock Index in SAP repo #1577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Perkins <[email protected]>
cwperks
requested review from
AWSHurneyt,
amsiglan,
eirsep,
engechas,
getsaurabh02,
goyamegh,
jowg-amazon,
lezzago,
praveensameneni,
riysaxen-amzn and
sbcd90
as code owners
5 tasks
…r commons Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
|
Raised opensearch-project/job-scheduler#833 to fix dep injection issue. |
AWSHurneyt
approved these changes
Sep 19, 2025
|
Merging this as its fixing a breaking change. Without this fix, SAP repo does not compile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes some logic that removes a lock directly from the Job Scheduler Lock index. Job Scheduler has a mechanism to expire locks if they've been acquired for too long and keeps lock entries for scheduled jobs if the job is disabled. If a plugin removes job metadata from a job index then the corresponding lock is also deleted by job-scheduler automatically.
This work should be delegated to Job Scheduler and should not live in another plugin's repo.
This PR contains a jarHell fix with companion PR: https://github.com/opensearch-project/security-analytics-commons/pull/27
^ Looks like that is currently a private repo so the link may not resolve
Related Issues
Resolves opensearch-project/job-scheduler#714 (comment)
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.