-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace _opendistro route to _plugins #2172
Replace _opendistro route to _plugins #2172
Conversation
1c2bf8f
to
f6d1e68
Compare
Signed-off-by: Andrey Pleskach <[email protected]>
f6d1e68
to
c49da4b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2172 +/- ##
=======================================
Coverage 71.46% 71.46%
=======================================
Files 97 97
Lines 2649 2649
Branches 403 403
=======================================
Hits 1893 1893
Misses 641 641
Partials 115 115 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Thank you @willyborankin. I just merged in the latest changes from main which had fixes for all CI checks. I expect most checks to pass now, except for the SAML tests for this PR. |
@cwperks as you expected only SAML tests failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@willyborankin I believe this assertion builder needs to change in security plugin before we merge this:
https://github.com/opensearch-project/security/blob/34735bb44a85c4e3f74fb666103b2d9670ce2ac6/src/main/java/com/amazon/dlic/auth/http/saml/Saml2SettingsProvider.java#L221
Closing this, as all paths will be removed in version 4.x." |
Description
The change is related to opensearch-project/security#5066 in the security plugin, which removes
_opendisto
routeWhat is the old behavior before changes and new behavior after changes?
Issues Resolved
[List any issues this PR will resolve (Is this a backport? If so, please add backport PR # and/or commits #)]
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.