Skip to content

Change API token index actions to use action listeners and limit to 100 tokens outstanding #5147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

derek-ho
Copy link
Collaborator

Description

Changes index operations on the api token index to be action listeners instead of action get. Also implements 100 api token limit.

Issues Resolved

[List any issues this PR will resolve]

Is this a backport? If so, please add backport PR # and/or commits #, and remove backport-failed label from the original PR.

Do these changes introduce new permission(s) to be displayed in the static dropdown on the front-end? If so, please open a draft PR in the security dashboards plugin and link the draft PR here

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 29.72973% with 78 lines in your changes missing coverage. Please review.

Project coverage is 71.37%. Comparing base (0edba23) to head (cdfc2aa).
Report is 88 commits behind head on feature/api-tokens.

Files with missing lines Patch % Lines
...arch/security/action/apitokens/ApiTokenAction.java 0.00% 67 Missing ⚠️
...ecurity/action/apitokens/ApiTokenIndexHandler.java 73.07% 7 Missing ⚠️
.../security/action/apitokens/ApiTokenRepository.java 76.47% 3 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                   @@
##           feature/api-tokens    #5147      +/-   ##
======================================================
- Coverage               71.46%   71.37%   -0.09%     
======================================================
  Files                     334      355      +21     
  Lines                   22552    23475     +923     
  Branches                 3590     3686      +96     
======================================================
+ Hits                    16117    16756     +639     
- Misses                   4642     4883     +241     
- Partials                 1793     1836      +43     
Files with missing lines Coverage Δ
...opensearch/security/action/apitokens/ApiToken.java 91.20% <100.00%> (ø)
.../security/action/apitokens/ApiTokenRepository.java 88.63% <76.47%> (ø)
...ecurity/action/apitokens/ApiTokenIndexHandler.java 81.81% <73.07%> (ø)
...arch/security/action/apitokens/ApiTokenAction.java 22.64% <0.00%> (ø)

... and 17 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

try {
XContentBuilder builder = channel.newBuilder();
builder.startObject();
builder.field("Api Token: ", token);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just have the field name be token. No need to include the colon here because this gets serialized to json and will get included.

Signed-off-by: Derek Ho <[email protected]>
@derek-ho derek-ho marked this pull request as ready for review March 24, 2025 14:30
@derek-ho derek-ho merged commit 8750e8b into opensearch-project:feature/api-tokens Mar 24, 2025
41 of 42 checks passed
@derek-ho derek-ho deleted the actionget-limit branch March 24, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants